DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :cc:content-type:content-transfer-encoding;
        b=RdDoNsIqYTdVRED/VNthZkDBZKqxWGG3y4CqZVnRHOtHhJ3/c3RuPNvbs4oJrUVctC
         4D3hYd5nmb3oOQIWZCkFwiqpNpmguf6lsbbgnNygt8LnOVIHIzQtrT6Gd6RCKR4Vhhed
         7adjePxyT9KUOXjOHQEaWoLTO/UeSyuRPzsVc=
MIME-Version: 1.0
In-Reply-To: <20090324212445.224fd377@lxorguk.ukuu.org.uk>
References: <1237929168-15341-13-git-send-email-stoyboyker@gmail.com>
	 <20090324212445.224fd377@lxorguk.ukuu.org.uk>
Date: Tue, 24 Mar 2009 16:31:54 -0500
Message-ID: <6d291e080903241431m3816e0a0sb55070e1d992054d@mail.gmail.com>
Subject: Re: [PATCH 12/13] [drivers/media] changed ioctls to unlocked
From: Stoyan Gaydarov <stoyboyker@gmail.com>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: linux-kernel@vger.kernel.org, linux-media@vger.kernel.org
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8BIT
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 929
Lines: 25

On Tue, Mar 24, 2009 at 4:24 PM, Alan Cox <alan@lxorguk.ukuu.org.uk> wrote:
>
>> -static int dabusb_ioctl (struct inode *inode, struct file *file, unsigned int cmd, unsigned long arg)
>> +static long dabusb_ioctl (struct file *file, unsigned int cmd, unsigned long arg)
>>  {
>> +     lock_kernel();
>>       pdabusb_t s = (pdabusb_t) file->private_data;
>
> After the variables or you'll get lots of warnings from gcc
>
>

Unfortunately I am not familiar with this driver and as such i was not
sure if the variable required the lock to be accessed or not so as to
play it safe i put it before the variable. But i can resubmit this
patch if there are no problems.

-- 

-Stoyan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/