Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756894AbZCYCyw (ORCPT ); Tue, 24 Mar 2009 22:54:52 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753176AbZCYCyn (ORCPT ); Tue, 24 Mar 2009 22:54:43 -0400 Received: from cn.fujitsu.com ([222.73.24.84]:55848 "EHLO song.cn.fujitsu.com" rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1752362AbZCYCym (ORCPT ); Tue, 24 Mar 2009 22:54:42 -0400 Message-ID: <49C99D0C.9070905@cn.fujitsu.com> Date: Wed, 25 Mar 2009 10:55:08 +0800 From: Li Zefan User-Agent: Thunderbird 2.0.0.9 (X11/20071115) MIME-Version: 1.0 To: Steven Rostedt CC: Ingo Molnar , Jens Axboe , Frederic Weisbecker , Arnaldo Carvalho de Melo , LKML Subject: Re: [PATCH 5/5] blktrace: print human-readable act_mask References: <49C893FC.9080905@cn.fujitsu.com> <49C89488.4030604@cn.fujitsu.com> <20090324155609.GA10365@elte.hu> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 709 Lines: 25 >> I'm really confused now. The prototype for blk_trace_str2mask has >> two parameters. It is used with two parameters above, but then it is used >> here with only one parameter. The blk_str2act_mask may have one, and that >> is what is replaced. >> >> What am I missing? > > I'm dyslexic :-p > > I see now... > > The proto-type is blk_trace_mask2str > > but this is blk_trace_str2mask > > Nevermind, > Never mind, your review is always appreciated. :) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/