Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758033AbZCYEKq (ORCPT ); Wed, 25 Mar 2009 00:10:46 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753611AbZCYEIl (ORCPT ); Wed, 25 Mar 2009 00:08:41 -0400 Received: from cantor2.suse.de ([195.135.220.15]:50364 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752039AbZCYEIh (ORCPT ); Wed, 25 Mar 2009 00:08:37 -0400 From: Nikanth Karthikesan Organization: suse.de To: Steven Rostedt Subject: Re: ftrace not working? Date: Wed, 25 Mar 2009 09:36:05 +0530 User-Agent: KMail/1.10.3 (Linux/2.6.27.19-3.2-default; KDE/4.1.3; x86_64; ; ) Cc: Frederic Weisbecker , Steven Rostedt , rusty@rustcorp.com.au, Ingo Molnar , KOSAKI Motohiro , linux-kernel@vger.kernel.org, stable@kernel.org References: <20090323083533.GE18837@elte.hu> <20090324201357.GB5975@nowhere> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200903250936.06349.knikanth@suse.de> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1363 Lines: 45 On Wednesday 25 March 2009 07:51:34 Steven Rostedt wrote: > On Tue, 24 Mar 2009, Frederic Weisbecker wrote: > > > Steve, Can you merge this. > > > > > > Thanks > > > Nikanth > > > > > > In tracer_alloc_buffers(), do not free tracing_cpumask and > > > tracing_buffer_mask on success. > > > > > > Signed-off-by: Nikanth Karthikesan > > > > > > --- > > > > > > diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c > > > index 17bb88d..98f609d 100644 > > > --- a/kernel/trace/trace.c > > > +++ b/kernel/trace/trace.c > > > @@ -3887,6 +3887,7 @@ __init static int tracer_alloc_buffers(void) > > > > > > register_die_notifier(&trace_die_notifier); > > > ret = 0; > > > + goto out; > > > > Ah I see. > > I've sent a fix for that already, it's on latest -tip > > http://git.kernel.org/?p=linux/kernel/git/tip/linux-2.6-tip.git;a=commit; > >h=2fc1dfbe17e7705c55b7a99da995fa565e26f151 > > Nikanth, > > Could you varify that tip is not an issue for you. > > http://people.redhat.com/~mingo/tip.git/readme.txt > Oh. That should fix it. It would be nice to have it in stable 2.6.29.1. Thanks Nikanth -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/