Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755222AbZCYET2 (ORCPT ); Wed, 25 Mar 2009 00:19:28 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751308AbZCYETR (ORCPT ); Wed, 25 Mar 2009 00:19:17 -0400 Received: from hrndva-omtalb.mail.rr.com ([71.74.56.124]:63937 "EHLO hrndva-omtalb.mail.rr.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751140AbZCYETR (ORCPT ); Wed, 25 Mar 2009 00:19:17 -0400 Date: Wed, 25 Mar 2009 00:19:14 -0400 (EDT) From: Steven Rostedt X-X-Sender: rostedt@gandalf.stny.rr.com To: Nikanth Karthikesan cc: Frederic Weisbecker , Steven Rostedt , Rusty Russell , Ingo Molnar , KOSAKI Motohiro , LKML , stable@kernel.org, gregkh@suse.de Subject: Re: ftrace not working? In-Reply-To: <200903250936.06349.knikanth@suse.de> Message-ID: References: <20090323083533.GE18837@elte.hu> <20090324201357.GB5975@nowhere> <200903250936.06349.knikanth@suse.de> User-Agent: Alpine 2.00 (DEB 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1596 Lines: 55 On Wed, 25 Mar 2009, Nikanth Karthikesan wrote: > On Wednesday 25 March 2009 07:51:34 Steven Rostedt wrote: > > On Tue, 24 Mar 2009, Frederic Weisbecker wrote: > > > > Steve, Can you merge this. > > > > > > > > Thanks > > > > Nikanth > > > > > > > > In tracer_alloc_buffers(), do not free tracing_cpumask and > > > > tracing_buffer_mask on success. > > > > > > > > Signed-off-by: Nikanth Karthikesan > > > > > > > > --- > > > > > > > > diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c > > > > index 17bb88d..98f609d 100644 > > > > --- a/kernel/trace/trace.c > > > > +++ b/kernel/trace/trace.c > > > > @@ -3887,6 +3887,7 @@ __init static int tracer_alloc_buffers(void) > > > > > > > > register_die_notifier(&trace_die_notifier); > > > > ret = 0; > > > > + goto out; > > > > > > Ah I see. > > > I've sent a fix for that already, it's on latest -tip > > > http://git.kernel.org/?p=linux/kernel/git/tip/linux-2.6-tip.git;a=commit; > > >h=2fc1dfbe17e7705c55b7a99da995fa565e26f151 > > > > Nikanth, > > > > Could you varify that tip is not an issue for you. > > > > http://people.redhat.com/~mingo/tip.git/readme.txt > > > > Oh. That should fix it. It would be nice to have it in stable 2.6.29.1. When it is pulled into Linus's tree, I'll send an note to Greg asking him to include it into stable. Thanks, -- Steve -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/