Date: Tue, 24 Mar 2009 22:21:09 -0600
From: Matthew Wilcox <matthew@wil.cx>
To: stoyboyker@gmail.com
Cc: linux-kernel@vger.kernel.org, James.Bottomley@HansenPartnership.com,
       linux-scsi@vger.kernel.org
Subject: Re: [PATCH 06/13] [scsi] changed ioctls to unlocked
Message-ID: <20090325042109.GP14127@parisc-linux.org>
References: <1237929168-15341-7-git-send-email-stoyboyker@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1237929168-15341-7-git-send-email-stoyboyker@gmail.com>
User-Agent: Mutt/1.5.13 (2006-08-11)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 833
Lines: 20

On Tue, Mar 24, 2009 at 04:12:41PM -0500, stoyboyker@gmail.com wrote:
> +static long osst_ioctl(struct file * file, unsigned int cmd_in,
> +	unsigned long arg)
>  {
> +	lock_kernel();
>  	int		      i, cmd_nr, cmd_type, blk, retval = 0;

Did you try compiling this?  If so, what compiler did you use?  You
*should* have got an error about mixing code and declarations.

-- 
Matthew Wilcox				Intel Open Source Technology Centre
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours.  We can't possibly take such
a retrograde step."
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/