MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Message-ID: <18889.61903.636761.471281@cargo.ozlabs.ibm.com>
Date: Wed, 25 Mar 2009 19:56:47 +1100
From: Paul Mackerras <paulus@samba.org>
To: Ingo Molnar <mingo@elte.hu>
Cc: Andrew Morton <akpm@linux-foundation.org>,
       Peter Zijlstra <a.p.zijlstra@chello.nl>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] perf_counter: allow and require one-page mmap on
	counting counters
In-Reply-To: <20090325082844.GA11217@elte.hu>
References: <18889.59409.260586.87939@cargo.ozlabs.ibm.com>
	<20090325082844.GA11217@elte.hu>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1402
Lines: 49

Ingo Molnar writes:

> * Paul Mackerras <paulus@samba.org> wrote:
> 
> > +++ b/kernel/perf_counter.c
> > @@ -1362,8 +1362,13 @@ static int perf_mmap(struct file *file, struct vm_area_struct *vma)
> >  	vma_size = vma->vm_end - vma->vm_start;
> >  	nr_pages = (vma_size / PAGE_SIZE) - 1;

To answer your question below... this:    ^^^

> >  
> > -	if (nr_pages == 0 || !is_power_of_2(nr_pages))
> > -		return -EINVAL;
> > +	if (counter->hw_event.record_type == PERF_RECORD_SIMPLE) {
> > +		if (nr_pages)
> > +			return -EINVAL;
> > +	} else {
> > +		if (nr_pages == 0 || !is_power_of_2(nr_pages))
> > +			return -EINVAL;
> > +	}
> 
> Hm, is_power_of_2() is buggy then as 1 page is a power of two as 
> well: 1 == 2^0.
> 
> Hm, it seems fine:
> 
>  static inline __attribute__((const))
>  bool is_power_of_2(unsigned long n)
>  {
>          return (n != 0 && ((n & (n - 1)) == 0));
>  }
> 
> that should return true for an input of 1.
> 
> What am i missing?
> 
> 	Ingo

We have one page as a header that contains the info for reading the
counter value in userspace plus the head pointer, followed by (for a
sampling counter) 2^N pages of ring buffer.

Paul.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/