Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755716AbZCYL7T (ORCPT ); Wed, 25 Mar 2009 07:59:19 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752901AbZCYL7G (ORCPT ); Wed, 25 Mar 2009 07:59:06 -0400 Received: from mtagate1.de.ibm.com ([195.212.17.161]:49356 "EHLO mtagate1.de.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752829AbZCYL7E (ORCPT ); Wed, 25 Mar 2009 07:59:04 -0400 Date: Wed, 25 Mar 2009 12:58:45 +0100 From: Heiko Carstens To: stoyboyker@gmail.com Cc: linux-kernel@vger.kernel.org, Stoyan Gaydarov , schwidefsky@de.ibm.com, linux-s390@vger.kernel.org Subject: Re: [PATCH 05/13] [s390] changed ioctls to unlocked Message-ID: <20090325125845.2923921b@osiris.boeblingen.de.ibm.com> In-Reply-To: <1237929168-15341-6-git-send-email-stoyboyker@gmail.com> References: <1237929168-15341-6-git-send-email-stoyboyker@gmail.com> X-Mailer: Claws Mail 3.5.0 (GTK+ 2.14.7; i486-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 786 Lines: 21 On Tue, 24 Mar 2009 16:12:40 -0500 stoyboyker@gmail.com wrote: > From: Stoyan Gaydarov > > Signed-off-by: Stoyan Gaydarov > --- > drivers/s390/char/tape_char.c | 47 +++++++++++++++++++++++---------- > drivers/s390/char/vmwatchdog.c | 57 ++++++++++++++++++++++++++-------------- > 2 files changed, 70 insertions(+), 34 deletions(-) Please resend with the comments that Jonathan made for your other patches: first define variables then lock_kernel() and also please use gotos. Thanks! -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/