Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761478AbZCYNYn (ORCPT ); Wed, 25 Mar 2009 09:24:43 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1757034AbZCYNYa (ORCPT ); Wed, 25 Mar 2009 09:24:30 -0400 Received: from hrndva-omtalb.mail.rr.com ([71.74.56.124]:37187 "EHLO hrndva-omtalb.mail.rr.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757807AbZCYNY3 (ORCPT ); Wed, 25 Mar 2009 09:24:29 -0400 Date: Wed, 25 Mar 2009 09:24:25 -0400 (EDT) From: Steven Rostedt X-X-Sender: rostedt@gandalf.stny.rr.com To: "K.Prasad" cc: Ingo Molnar , Linux Kernel Mailing List , Alan Stern , Andrew Morton , Benjamin Herrenschmidt , Frederic Weisbecker , maneesh@linux.vnet.ibm.com, Roland McGrath Subject: Re: [Patch 11/11] ftrace plugin for kernel symbol tracing using HW Breakpoint interfaces - v3 In-Reply-To: <20090325063517.GA5825@in.ibm.com> Message-ID: References: <20090324152028.754123712@K.Prasad> <20090324152811.GL17918@in.ibm.com> <20090325063517.GA5825@in.ibm.com> User-Agent: Alpine 2.00 (DEB 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2840 Lines: 100 On Wed, 25 Mar 2009, K.Prasad wrote: > On Tue, Mar 24, 2009 at 08:58:11PM +0530, K.Prasad wrote: > > This patch adds an ftrace plugin to detect and profile memory access over > > kernel variables. It uses HW Breakpoint interfaces to 'watch memory > > addresses. > > > > Signed-off-by: K.Prasad > > --- > > kernel/trace/Kconfig | 21 + > > kernel/trace/Makefile | 1 > > kernel/trace/trace.h | 25 + > > kernel/trace/trace_ksym.c | 555 ++++++++++++++++++++++++++++++++++++++++++ > > kernel/trace/trace_selftest.c | 36 ++ > > 5 files changed, 638 insertions(+) > > > > Submitting the revised patch 11/11 and not reposting the entire > patchset. > > Changelog > --------- > - Checking for the appropriate tracer type in the .print_line handler function > > Please find the new patch below. > > Thanks, > K.Prasad > > > ftrace plugin for kernel symbol tracing using HW Breakpoint interfaces - v2 > > This patch adds an ftrace plugin to detect and profile memory access over > kernel variables. It uses HW Breakpoint interfaces to 'watch memory > addresses. > > Signed-off-by: K.Prasad > --- > kernel/trace/Kconfig | 21 + > kernel/trace/Makefile | 1 > kernel/trace/trace.h | 25 + > kernel/trace/trace_ksym.c | 558 ++++++++++++++++++++++++++++++++++++++++++ > kernel/trace/trace_selftest.c | 36 ++ > 5 files changed, 641 insertions(+) > > +static enum print_line_t ksym_trace_output(struct trace_iterator *iter) > +{ > + struct trace_entry *entry = iter->ent; > + struct trace_seq *s = &iter->seq; > + struct trace_ksym *field; > + char str[KSYM_SYMBOL_LEN]; > + int ret; > + > + if (entry->type != TRACE_KSYM) > + return TRACE_TYPE_UNHANDLED; Looks good. Acked-by:Steven Rostedt Thanks, -- Steve > + > + trace_assign_type(field, entry); > + > + ret = trace_seq_printf(s, "%-15s %-5d %-3d %-20s ", field->p_name, > + entry->pid, iter->cpu, field->ksym_name); > + if (!ret) > + return TRACE_TYPE_PARTIAL_LINE; > + > + switch (field->ksym_hbp->info.type) { > + case HW_BREAKPOINT_WRITE: > + ret = trace_seq_printf(s, " W "); > + break; > + case HW_BREAKPOINT_RW: > + ret = trace_seq_printf(s, " RW "); > + break; > + default: > + return TRACE_TYPE_PARTIAL_LINE; > + } > + > + if (!ret) > + return TRACE_TYPE_PARTIAL_LINE; > + > + sprint_symbol(str, field->ip); > + ret = trace_seq_printf(s, "%-20s\n", str); > + if (!ret) > + return TRACE_TYPE_PARTIAL_LINE; > + > + return TRACE_TYPE_HANDLED; > +} > + -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/