Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761567AbZCYNmU (ORCPT ); Wed, 25 Mar 2009 09:42:20 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754600AbZCYNmJ (ORCPT ); Wed, 25 Mar 2009 09:42:09 -0400 Received: from hrndva-omtalb.mail.rr.com ([71.74.56.123]:46530 "EHLO hrndva-omtalb.mail.rr.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753877AbZCYNmI (ORCPT ); Wed, 25 Mar 2009 09:42:08 -0400 Date: Wed, 25 Mar 2009 09:42:04 -0400 (EDT) From: Steven Rostedt X-X-Sender: rostedt@gandalf.stny.rr.com To: Ingo Molnar cc: linux-kernel@vger.kernel.org, Andrew Morton , Thomas Gleixner , Peter Zijlstra , Roland McGrath , Nick Piggin , Steven Rostedt Subject: Re: [PATCH 1/5] ptrace: remove incorrect unlikelys In-Reply-To: <20090325072129.GB25833@elte.hu> Message-ID: References: <20090325051920.406564281@goodmis.org> <20090325052022.747507467@goodmis.org> <20090325072129.GB25833@elte.hu> User-Agent: Alpine 2.00 (DEB 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1164 Lines: 30 On Wed, 25 Mar 2009, Ingo Molnar wrote: > > diff --git a/arch/x86/kernel/ptrace.c b/arch/x86/kernel/ptrace.c > > index 06ca07f..74a16db 100644 > > --- a/arch/x86/kernel/ptrace.c > > +++ b/arch/x86/kernel/ptrace.c > > @@ -1421,7 +1421,7 @@ asmregparm long syscall_trace_enter(struct pt_regs *regs) > > tracehook_report_syscall_entry(regs)) > > ret = -1L; > > > > - if (unlikely(current->audit_context)) { > > + if (current->audit_context) { > > i suspect you got this result because you are running Fedora with > auditd enabled and running, right? Does SuSE and Ubuntu run with > auditing enabled as well? If yes then removing this annotation would > be right - otherwise the auditing-enabled case is considered the > less likely variant. (despite it being 100% wrong for your > particular configuration) I'm running an old RHEL 5.1 box. I guess we can look at what the other distros run. -- Steve -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/