Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760310AbZCYRRb (ORCPT ); Wed, 25 Mar 2009 13:17:31 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754871AbZCYRRX (ORCPT ); Wed, 25 Mar 2009 13:17:23 -0400 Received: from cantor.suse.de ([195.135.220.2]:50809 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753840AbZCYRRX (ORCPT ); Wed, 25 Mar 2009 13:17:23 -0400 Message-ID: <49CA6856.9090005@suse.de> Date: Thu, 26 Mar 2009 01:22:30 +0800 From: Coly Li Reply-To: coly.li@suse.de Organization: SuSE Labs User-Agent: Thunderbird 2.0.0.19 (X11/20081227) MIME-Version: 1.0 To: Randy Dunlap Cc: LKML , Andrew Morton Subject: Re: [PATCH] reiserfs: select CRC32 and BITREVERSE for REISERFS_FS Kconfig entry References: <49CA629E.7040701@suse.de> <49CA64BE.2090804@oracle.com> In-Reply-To: <49CA64BE.2090804@oracle.com> X-Enigmail-Version: 0.95.7 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1334 Lines: 40 Randy Dunlap Wrote: > Coly Li wrote: >> In patch fs-reiserfs-return-f_fsid-for-statfs2-v2.patch (from mmotm), crc32_le() >> is referenced. If reiserfs is compiled into kernel and crc32_le() is compiled as >> kernel module, there might be a compiling error as: >> fs/built-in.o: In function `reiserfs_statfs': >> super.c:(.text+0x7332b): undefined reference to `crc32_le' >> super.c:(.text+0x7333f): undefined reference to `crc32_le' >> This patch select CRC32 and BITREVERSE for REISERFS_FS Kconfig entry, which >> indicates compiling crc32_le() into kernel. >> >> Thanks to Randy Dunlap for pointing out this error and providing helpful solution. >> >> Signed-off-by: Coly Li >> Cc: Randy Dunlap > > Acked-by: Randy Dunlap > Tested-by: Randy Dunlap Hi Randy, You give me an important enlightenment, for my return-f_fsid-for-statfs2 patch serial, selecting CRC32 and BITREVERSE is necessary ... Andrew, I will check it and send out fix ASAP. Thanks. -- Coly Li SuSE Labs -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/