Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756532AbZCYUqx (ORCPT ); Wed, 25 Mar 2009 16:46:53 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754848AbZCYUq0 (ORCPT ); Wed, 25 Mar 2009 16:46:26 -0400 Received: from hera.kernel.org ([140.211.167.34]:40407 "EHLO hera.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754718AbZCYUqZ (ORCPT ); Wed, 25 Mar 2009 16:46:25 -0400 Subject: Re: [PATCH][GIT PULL] x86, function-graph: only save return values on x86_64 From: Jaswinder Singh Rajput To: Steven Rostedt Cc: linux kernel , Frederic Weisbecker , Ingo Molnar , Tim Bird , Ingo Molnar , Abhishek Sagar , Peter Zijlstra , Thomas Gleixner In-Reply-To: References: <49C936CA.8070800@am.sony.com> <20090324213618.GC5975@nowhere> <20090324214846.GB29509@elte.hu> <20090324215738.GD5975@nowhere> Content-Type: text/plain Date: Thu, 26 Mar 2009 02:15:34 +0530 Message-Id: <1238013934.2500.81.camel@ht.satnam> Mime-Version: 1.0 X-Mailer: Evolution 2.24.5 (2.24.5-1.fc10) Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2643 Lines: 89 On Wed, 2009-03-25 at 16:27 -0400, Steven Rostedt wrote: > Ingo, > > Please pull the latest tip/tracing/function-graph tree, which can be found at: > > git://git.kernel.org/pub/scm/linux/kernel/git/rostedt/linux-2.6-trace.git > tip/tracing/function-graph > > > Steven Rostedt (1): > x86, function-graph: only save return values on x86_64 > > ---- > arch/x86/kernel/entry_64.S | 19 +++---------------- > 1 files changed, 3 insertions(+), 16 deletions(-) > --------------------------- > commit d5b754b2208b1c22691a7cd5d1a65398b5973d74 > Author: Steven Rostedt > Date: Wed Mar 25 14:30:04 2009 -0400 > > x86, function-graph: only save return values on x86_64 > > Impact: speed up > > The return to handler portion of the function graph tracer should only > need to save the return values. The caller already saved off the > registers that the callee can modify. The returning function already > saved the registers it modified. When we call our own trace function > it too will save the registers that the callee must restore. > > There's no reason to save off anything more that the registers used > to return the values. > > Note, I did a complete kernel build with this modification and the > function graph tracer running on x86_64. > > Signed-off-by: Steven Rostedt > > diff --git a/arch/x86/kernel/entry_64.S b/arch/x86/kernel/entry_64.S > index a331ec3..1ac9986 100644 > --- a/arch/x86/kernel/entry_64.S > +++ b/arch/x86/kernel/entry_64.S > @@ -147,27 +147,14 @@ END(ftrace_graph_caller) > GLOBAL(return_to_handler) > subq $80, %rsp > > + /* Save the return values */ > movq %rax, (%rsp) > - movq %rcx, 8(%rsp) > - movq %rdx, 16(%rsp) > - movq %rsi, 24(%rsp) > - movq %rdi, 32(%rsp) > - movq %r8, 40(%rsp) > - movq %r9, 48(%rsp) > - movq %r10, 56(%rsp) > - movq %r11, 64(%rsp) > + movq %rdx, 8(%rsp) > > call ftrace_return_to_handler > > movq %rax, 72(%rsp) > - movq 64(%rsp), %r11 > - movq 56(%rsp), %r10 > - movq 48(%rsp), %r9 > - movq 40(%rsp), %r8 > - movq 32(%rsp), %rdi > - movq 24(%rsp), %rsi > - movq 16(%rsp), %rdx > - movq 8(%rsp), %rcx > + movq 8(%rsp), %rdx > movq (%rsp), %rax > addq $72, %rsp > retq hmm, is this gonna work: movq %rax, 16(%rsp) movq 8(%rsp), %rdx movq (%rsp), %rax addq $16, %rsp retq -- JSR -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/