Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757592AbZCYX3r (ORCPT ); Wed, 25 Mar 2009 19:29:47 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755737AbZCYX31 (ORCPT ); Wed, 25 Mar 2009 19:29:27 -0400 Received: from byss.tchmachines.com ([208.76.80.75]:55508 "EHLO byss.tchmachines.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756755AbZCYX30 (ORCPT ); Wed, 25 Mar 2009 19:29:26 -0400 Date: Wed, 25 Mar 2009 16:29:21 -0700 From: Ravikiran G Thirumalai To: Jeremy Fitzhardinge Cc: Ingo Molnar , Yinghai Lu , Thomas Gleixner , "H. Peter Anvin" , Andrew Morton , "linux-kernel@vger.kernel.org" , shai@scalex86.org Subject: Re: [PATCH] x86: don't compile vsmp_64 for 32bit Message-ID: <20090325232921.GL7278@localdomain> References: <20090227001757.GE27240@localdomain> <20090228094430.GH12095@elte.hu> <20090302235120.GF27240@localdomain> <20090322124818.GA31466@elte.hu> <20090324061429.GH7278@localdomain> <20090324091035.GA6605@elte.hu> <20090325185138.GI7278@localdomain> <49CAAD2E.3060904@goop.org> <20090325223642.GK7278@localdomain> <49CABB25.8040106@goop.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <49CABB25.8040106@goop.org> User-Agent: Mutt/1.5.15+20070412 (2007-04-11) X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - byss.tchmachines.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - scalex86.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1394 Lines: 33 On Wed, Mar 25, 2009 at 04:15:49PM -0700, Jeremy Fitzhardinge wrote: > Ravikiran G Thirumalai wrote: >> On Wed, Mar 25, 2009 at 03:16:14PM -0700, Jeremy Fitzhardinge wrote: >> >>> Ravikiran G Thirumalai wrote: >>> >>>> It is already there, and has been there! But we still need to make >>>> vsmp64.c compile only when CONFIG_X86_64 is defined no? >>>> >>> I still think you should restructure it so that vsmp_64.c only gets >>> compiled with CONFIG_X86_VSMP enabled. Having all that stuff compiled >>> into every kernel seems pretty pointless. >>> >>> >> >> Well, not everything gets compiled in. Only the is_vsmp_box() logic and >> related stuff gets compiled in. Other paravirt related stuff in vsmp64.c >> depends on CONFIG_PARAVIRT. >> > > Sure, but it would be cleaner if the whole file were controlled by > CONFIG_X86_VSMP. is_vsmp_box() is already defined as const inline > returning 0 if !CONFIG_X86_VSMP. > The point in this thread was, is_vsmp_box() needs to be meaningful even when CONFIG_X86_VSMP is not on. This is needed because is_vsmp_box() is used to determine if the platform has reliable tscs. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/