Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756401AbZCZAeX (ORCPT ); Wed, 25 Mar 2009 20:34:23 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755067AbZCZAeH (ORCPT ); Wed, 25 Mar 2009 20:34:07 -0400 Received: from e35.co.us.ibm.com ([32.97.110.153]:57947 "EHLO e35.co.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753099AbZCZAeD (ORCPT ); Wed, 25 Mar 2009 20:34:03 -0400 From: Jay Vosburgh To: Jiri Pirko cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org, jgarzik@pobox.com, davem@davemloft.net, shemminger@linux-foundation.org, bridge@lists.linux-foundation.org, bonding-devel@lists.sourceforge.net, kaber@trash.net, mschmidt@redhat.com, dada1@cosmosbay.com Subject: Re: [PATCH] bonding: allow bond in mode balance-alb to work properly in bridge -try3 In-reply-to: <20090325174405.GM3437@psychotron.englab.brq.redhat.com> References: <20090313183303.GF3436@psychotron.englab.brq.redhat.com> <20090325151937.GI3437@psychotron.englab.brq.redhat.com> <28445.1237998713@death.nxdomain.ibm.com> <20090325174405.GM3437@psychotron.englab.brq.redhat.com> Comments: In-reply-to Jiri Pirko message dated "Wed, 25 Mar 2009 18:44:05 +0100." X-Mailer: MH-E 8.0.3; nmh 1.3-RC3; GNU Emacs 22.2.1 Date: Wed, 25 Mar 2009 17:34:07 -0700 Message-ID: <8854.1238027647@death.nxdomain.ibm.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1377 Lines: 38 Jiri Pirko wrote: >Wed, Mar 25, 2009 at 05:31:53PM CET, fubar@us.ibm.com wrote: [...] >>> #if defined(CONFIG_BRIDGE) || defined (CONFIG_BRIDGE_MODULE) >>> /* These hooks defined here for ATM */ >>> struct net_bridge; >>>@@ -2251,10 +2258,12 @@ int netif_receive_skb(struct sk_buff *skb) >>> null_or_orig = NULL; >>> orig_dev = skb->dev; >>> if (orig_dev->master) { >>>- if (skb_bond_should_drop(skb)) >>>+ if (skb_bond_should_drop(skb)) { >>> null_or_orig = orig_dev; /* deliver only exact match */ >>>- else >>>+ } else { >>> skb->dev = orig_dev->master; >>>+ bond_change_dest_hook(skb); >> >> Since you put the hook outside of the skb_bond_should_drop >>function, does the VLAN accelerated receive path do the right thing if, >>e.g., there's a VLAN on top of bonding and that VLAN is part of the >>bridge? Jiri: not trying to be pushy, but you didn't address the above question about the VLAN path, and I just want to make sure that you saw it (it was at the bottom of a long email, so I fear you may not have seen it). -J --- -Jay Vosburgh, IBM Linux Technology Center, fubar@us.ibm.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/