Message-ID: <49CAE425.5050009@kernel.org>
Date: Thu, 26 Mar 2009 11:10:45 +0900
From: Tejun Heo <tj@kernel.org>
User-Agent: Thunderbird 2.0.0.19 (X11/20081227)
MIME-Version: 1.0
To: Boaz Harrosh <bharrosh@panasas.com>
CC: bzolnier@gmail.com, linux-kernel@vger.kernel.org, axboe@kernel.dk,
       linux-ide@vger.kernel.org
Subject: Re: [PATCH 03/14] block: implement blk_rq_map_kern_prealloc()
References: <1237910776-10983-1-git-send-email-tj@kernel.org> <1237910776-10983-4-git-send-email-tj@kernel.org> <49CA4B4B.50408@panasas.com>
In-Reply-To: <49CA4B4B.50408@panasas.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1442
Lines: 45

Hello,

Boaz Harrosh wrote:
> I have a similar, totally unrelated patch queued, perhaps we can unify
> the efforts, to satisfy both our needs in one stone.
> 
> I've sent this patch:
> http://www.spinics.net/lists/linux-scsi/msg34082.html
> 
> In an effort to un-export blk_rq_append_bio().
> 
> Perhaps you could reorder the code below a bit?
> 
> My proposal is:
> * blk_rq_map_kern_prealloc => is simplified to be
>     int blk_rq_map_bio(struct request_queue *q, struct request *rq,
> 		       struct bio *bio);
> 
> * The extra checks currently inside blk_rq_map_kern_prealloc are moved
>   to bio_map_kern_prealloc()
> 
> * Users call bio_map_kern_prealloc() directly and then use blk_rq_map_bio()
>   in a two stage process.
> 
> So blk_rq_map_bio becomes a BLOCK_PC command's way of a
> pre-allocated bio the way FS_PC commands use generic_make_request.

Sounds good.  I'll make the change.

> Thanks for doing all this. BTW' how close are we to remove req->data
> and req->buffer

Those patches will be going out later today.  It will also kill
rq->hard_* and rq->*nr_sectors.  Single byte-granual data length for
all along with single way to carray data via bio! :-)

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/