From: "Cai, Cliff" <Cliff.Cai@analog.com>
Content-Class: urn:content-classes:message
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 8BIT
Subject: RE: [PATCH] mmc: align data size for host which only supports power-of-2 block
Date: Thu, 26 Mar 2009 10:22:54 +0800
Message-ID: <0F1B54C89D5F954D8535DB252AF412FA03C5E04A@chinexm1.ad.analog.com>
In-Reply-To: <20090325202335.42abc221@mjolnir.ossman.eu>
Thread-Topic: [PATCH] mmc: align data size for host which only supports power-of-2 block
Thread-Index: AcmtfzfgotKrBzh8Tr2n1vUhywDMJAAOgGOA
References: <1236309321-23955-1-git-send-email-cooloney@kernel.org><20090314213038.4d14526e@mjolnir.ossman.eu><0F1B54C89D5F954D8535DB252AF412FA03C5D7C5@chinexm1.ad.analog.com> <20090325202335.42abc221@mjolnir.ossman.eu>
To: "Pierre Ossman" <drzeus-mmc@drzeus.cx>
CC: "Bryan Wu" <cooloney@kernel.org>, <linux-kernel@vger.kernel.org>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1379
Lines: 49


>
 

>-----Original Message-----
>From: Pierre Ossman [mailto:drzeus-mmc@drzeus.cx] 
>Sent: Thursday, March 26, 2009 3:24 AM
>To: Cai, Cliff
>Cc: Bryan Wu; linux-kernel@vger.kernel.org
>Subject: Re: [PATCH] mmc: align data size for host which only 
>supports power-of-2 block
>
>On Wed, 25 Mar 2009 11:22:25 +0800
>"Cai, Cliff" <Cliff.Cai@analog.com> wrote:
>
>> >
>> >This patch seems premature as there is no associated 
>modification of 
>> >any of the host drivers.
>> 
>> The SDH on Blackfin BF54x/BF51x only supports power-of-2 block 
>> transfer,we will soon Send the sdh driver to mainline as well.
>> 
>
>Ok. Looking forward to it. :)
>
>> >Padding to a power of two size can also mean a rather large 
>> >padding. We might need to check the host data limits after 
>> >doing the adjustment.
>> 
>> Yes,but it's the higher level driver's job. 
>> 
>
>mmc_align_data_size() shouldn't be adjusting the size to something it
>can easily determine that it's invalid.

Should I create a new function to do the power-of-2 adjustment?
Or any ideal way to do it?
Otherwise,the SDH almost can't be used as sdio host.

Thanks 

Cliff
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/