Message-ID: <49CAE64B.4020707@cn.fujitsu.com>
Date: Thu, 26 Mar 2009 10:19:55 +0800
From: Lai Jiangshan <laijs@cn.fujitsu.com>
User-Agent: Thunderbird 2.0.0.6 (Windows/20070728)
MIME-Version: 1.0
To: Steven Rostedt <srostedt@redhat.com>
CC: Ingo Molnar <mingo@elte.hu>, Frederic Weisbecker <fweisbec@gmail.com>,
       LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] trace_stat: keep original order
References: <49C9F23F.5040307@cn.fujitsu.com> <1237991798.22033.7.camel@localhost.localdomain>
In-Reply-To: <1237991798.22033.7.camel@localhost.localdomain>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 976
Lines: 30

Steven Rostedt wrote:
> On Wed, 2009-03-25 at 16:58 +0800, Lai Jiangshan wrote:
>> Impact: make trace_stat files show items with the original order
>>
>> trace_stat tracer reverse the items, it makes the output
>> looks a little ugly.
>>
>> Example, when we read trace_stat/workqueues, we get cpu#7's stat.
>> at first, and then cpu#6... cpu#0.
>>
> 
> This doesn't reverse the order of the annotated branch profiler, does
> it?
> 

The annotated ftrace_branch_data are orderless. So it's OK
with or without this fix.

(From code, not test) If this fix applied,
__start_annotated_branch_profile is shown at the first, and then
__start_annotated_branch_profile + 1... and
__stop_annotated_branch_profile is shown at the last.

Lai

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/