Date: Thu, 26 Mar 2009 11:00:58 +0100
From: Ingo Molnar <mingo@elte.hu>
To: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>, linux-kernel@vger.kernel.org,
       Mike Galbraith <efault@gmx.de>, Arjan van de Ven <arjan@infradead.org>,
       Wu Fengguang <fengguang.wu@intel.com>
Subject: Re: [RFC][PATCH 2/3] perf_counter: executable mmap() information
Message-ID: <20090326100058.GD19826@elte.hu>
References: <20090325210419.408653980@chello.nl> <20090325210542.293237509@chello.nl> <18891.6159.109191.255560@drongo.ozlabs.ibm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <18891.6159.109191.255560@drongo.ozlabs.ibm.com>
User-Agent: Mutt/1.5.18 (2008-05-17)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1080
Lines: 30


* Paul Mackerras <paulus@samba.org> wrote:

> Peter Zijlstra writes:
> 
> > --- linux-2.6.orig/include/linux/perf_counter.h
> > +++ linux-2.6/include/linux/perf_counter.h
> > @@ -137,7 +137,9 @@ struct perf_counter_hw_event {
> >  				exclude_kernel :  1, /* ditto kernel          */
> >  				exclude_hv     :  1, /* ditto hypervisor      */
> >  				exclude_idle   :  1, /* don't count when idle */
> > -				include_tid    :  1, /* include the tid */
> > +				include_tid    :  1, /* include the tid       */
> > +				mmap           :  1, /* include mmap data     */
> > +				munmap         :  1, /* include munmap data   */
> >  
> >  				__reserved_1   : 54;
> 
> Nit: need to adjust the size of __reserved_1 here.  Or maybe just 
> get rid of it?

it's nice to have a constant reminder about how many bits there are 
left.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/