Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757769AbZCZNNq (ORCPT ); Thu, 26 Mar 2009 09:13:46 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756630AbZCZNNd (ORCPT ); Thu, 26 Mar 2009 09:13:33 -0400 Received: from tx2ehsobe003.messaging.microsoft.com ([65.55.88.13]:56767 "EHLO TX2EHSOBE006.bigfish.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1757517AbZCZNNb (ORCPT ); Thu, 26 Mar 2009 09:13:31 -0400 X-BigFish: VPS-37(zz1432R62a3L98dR936eQ1805M936fKzz1202hzz5a6ciz32i6bh43j61h) X-Spam-TCS-SCL: 0:0 X-FB-SS: 5, X-WSS-ID: 0KH47D1-03-EOE-01 Date: Thu, 26 Mar 2009 14:12:36 +0100 From: Robert Richter To: Jaswinder Singh Rajput CC: Ingo Molnar , x86 maintainers , LKML , Andi Kleen Subject: Re: [PATCH -tip] x86: unification of cpu/bugs.c Message-ID: <20090326131236.GE3226@erda.amd.com> References: <1238068930.2507.1.camel@ht.satnam> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <1238068930.2507.1.camel@ht.satnam> User-Agent: Mutt/1.5.16 (2007-06-09) X-OriginalArrivalTime: 26 Mar 2009 13:12:37.0382 (UTC) FILETIME=[88C2DA60:01C9AE14] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1773 Lines: 71 On 26.03.09 17:32:09, Jaswinder Singh Rajput wrote: > This patch is based on -tip x86/core: > > From: Jaswinder Singh Rajput > Date: Thu, 26 Mar 2009 17:14:38 +0530 > Subject: [PATCH] x86: unification of cpu/bugs.c > > Impact: Unification, cleanup > > Signed-off-by: Jaswinder Singh Rajput > --- > arch/x86/kernel/cpu/Makefile | 5 +-- > arch/x86/kernel/cpu/bugs.c | 74 ++++++++++++++++++++++++++-------------- > arch/x86/kernel/cpu/bugs_64.c | 33 ------------------ > 3 files changed, 50 insertions(+), 62 deletions(-) > delete mode 100644 arch/x86/kernel/cpu/bugs_64.c Jaswinder, please send separate patches for separate changes (e.g. make separate whitespace changes). [...] > @@ -91,14 +98,14 @@ static void __init check_hlt(void) > > printk(KERN_INFO "Checking 'hlt' instruction... "); > if (!boot_cpu_data.hlt_works_ok) { > - printk("disabled\n"); > + printk(KERN_INFO "disabled\n"); All this is continuing the printk above. -Robert > return; > } > halt(); > halt(); > halt(); > halt(); > - printk("OK.\n"); > + printk(KERN_INFO "OK.\n"); > } > > /* > @@ -122,9 +129,9 @@ static void __init check_popad(void) > * CPU hard. Too bad. > */ > if (res != 12345678) > - printk("Buggy.\n"); > + printk(KERN_INFO "Buggy.\n"); > else > - printk("OK.\n"); > + printk(KERN_INFO "OK.\n"); > #endif > } > [...] -- Advanced Micro Devices, Inc. Operating System Research Center email: robert.richter@amd.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/