Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758688AbZCZO4X (ORCPT ); Thu, 26 Mar 2009 10:56:23 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753553AbZCZO4O (ORCPT ); Thu, 26 Mar 2009 10:56:14 -0400 Received: from mtagate7.uk.ibm.com ([195.212.29.140]:33848 "EHLO mtagate7.uk.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754507AbZCZO4N (ORCPT ); Thu, 26 Mar 2009 10:56:13 -0400 Date: Thu, 26 Mar 2009 15:56:09 +0100 From: Cornelia Huck To: Alan Stern Cc: Tejun Heo , "Eric W. Biederman" , Alex Chiang , , , , Subject: Re: [RFC PATCH 0/3] sysfs: allow suicide Message-ID: <20090326155609.56a662cf@gondolin> In-Reply-To: References: <49CAF840.2030308@gmail.com> Organization: IBM Deutschland Research & Development GmbH Vorsitzender des Aufsichtsrats: Martin Jetter =?ISO-8859-15?Q?Gesch=E4ftsf=FChrung:?= Erich Baier Sitz der Gesellschaft: =?ISO-8859-15?Q?B=F6blingen?= Registergericht: Amtsgericht Stuttgart, HRB 243294 X-Mailer: Claws Mail 3.7.1 (GTK+ 2.14.7; i486-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1281 Lines: 28 On Thu, 26 Mar 2009 10:21:23 -0400 (EDT), Alan Stern wrote: > The idea is that this would come in useful both for suicidal sysfs > attributes and for hot-unplug events detected by an interrupt handler. Yes; the ccw bus uses it's own workqueue, so it doesn't need device_schedule_callback() to commit suicide. I guess other busses could do the same. > > But there's something I'm not clear on. If hot-unplug events are > detected by an interrupt handler, then what about hot-plug events? > Wouldn't they be detected by the same interrupt handler? Obviously you > can't register new devices in interrupt context, so there must be a > workqueue or kernel thread involved somewhere. Shouldn't the two types > of events be managed by the same workqueue/thread? They should, you want to serialize plug/unplug. You'll even want to use the same queue for plug/unplug not detected in interrupt context. The next question is how granular those workqueues should be. Per subsystem? Per bus? Something else? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/