Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759436AbZCZQXx (ORCPT ); Thu, 26 Mar 2009 12:23:53 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754773AbZCZQXn (ORCPT ); Thu, 26 Mar 2009 12:23:43 -0400 Received: from smtp1.linux-foundation.org ([140.211.169.13]:39581 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756095AbZCZQXm (ORCPT ); Thu, 26 Mar 2009 12:23:42 -0400 Date: Thu, 26 Mar 2009 09:15:11 -0700 From: Andrew Morton To: Al Viro Cc: Pekka Enberg , Hua Zhong , Steven Rostedt , linux-kernel@vger.kernel.org, Ingo Molnar , Thomas Gleixner , Peter Zijlstra , Roland McGrath , Nick Piggin , Steven Rostedt , Christoph Lameter , Matt Mackall Subject: Re: [PATCH 2/5] mm: remove unlikly NULL from kfree Message-Id: <20090326091511.a4e88b2f.akpm@linux-foundation.org> In-Reply-To: <20090326161019.GT28946@ZenIV.linux.org.uk> References: <20090325051920.406564281@goodmis.org> <20090325052023.071564146@goodmis.org> <84144f020903250034j24e1782bt5f73809b9349346c@mail.gmail.com> <009101c9ad20$1ae231c0$50a69540$@com> <1237968394.30175.12.camel@penberg-laptop> <84144f020903250651o13c723cgf64643091459a5ac@mail.gmail.com> <20090326161019.GT28946@ZenIV.linux.org.uk> X-Mailer: Sylpheed 2.4.8 (GTK+ 2.12.5; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 542 Lines: 12 On Thu, 26 Mar 2009 16:10:19 +0000 Al Viro wrote: > We certainly can add explicit check, but that'll keep asking for > patches "removing useless check". The same applies to other places, > really. Such patches are easily prevented by commenting the exceptional cases. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/