Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759094AbZCZRMf (ORCPT ); Thu, 26 Mar 2009 13:12:35 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753427AbZCZRMN (ORCPT ); Thu, 26 Mar 2009 13:12:13 -0400 Received: from Cpsmtpm-eml110.kpnxchange.com ([195.121.3.14]:49530 "EHLO CPSMTPM-EML110.kpnxchange.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751167AbZCZRMN (ORCPT ); Thu, 26 Mar 2009 13:12:13 -0400 From: Frans Pop To: Andrew Morton Subject: Re: relatime: update once per day patches (was: ext3 IO latency measurements) Date: Thu, 26 Mar 2009 18:12:04 +0100 User-Agent: KMail/1.9.9 Cc: Linus Torvalds , mingo@elte.hu, tytso@mit.edu, jack@suse.cz, alan@lxorguk.ukuu.org.uk, arjan@infradead.org, a.p.zijlstra@chello.nl, npiggin@suse.de, jens.axboe@oracle.com, drees76@gmail.com, jesper@krogh.cc, linux-kernel@vger.kernel.org, oleg@redhat.com, roland@redhat.com References: <20090325123744.GK23439@duck.suse.cz> <20090326092454.b74e3f96.akpm@linux-foundation.org> In-Reply-To: <20090326092454.b74e3f96.akpm@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200903261812.09153.elendil@planet.nl> X-OriginalArrivalTime: 26 Mar 2009 17:12:09.0974 (UTC) FILETIME=[FF7E5960:01C9AE35] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2118 Lines: 45 On Thursday 26 March 2009, Andrew Morton wrote: > On Thu, 26 Mar 2009 09:14:28 -0700 (PDT) Linus Torvalds wrote: > > I generally agree witht he "leave policy to user space" people, but > > this is an area where (a) user space has shown itself to not get it > > right (ie people don't do even the existing relatime because distros > > don't) and (b) what's the alternative? > > > > > I (and others) pointed out that it would be better to implement > > > this as a mount option. That suggestion was met with varying > > > sillinesses and that is where things stand. > > > > I'd suggest first just doing the 24 hour thing, and then, IF user > > space actually ever gets its act together, and people care, and they > > _ask_ for a mount option, that's when it's worth doing. > > We wouldn't normally just enable the new feature by default because it > changes kernel behaviour. Userspace needs to be changed in some manner > to opt-in. One way it's `mount -o remount', the other way it's a poke > in /proc. What change are you talking about here exactly? The "change relatime to have a 24 hour safeguard" of Matthes's first patch or the "enable relatime by default" options in the second patch? For the first I don't think it's that big a deal as it is a change that makes the behavior of relatime safer and not riskier. Also, it's something people have argued should have been part of the initial functionality of relatime (it was part of the discussion back then), and finally for a lot of users it's already current functionality as major distros already do include the patch. For the second, I can see your point and can understand reservations to make enabling relatime a kernel config option. Speaking exclusively for myself, I would be happy enough if only the first of Matthew's patches would get accepted. Cheers, FJP -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/