Subject: Re: [PATCH 2/6] drm/i915: Make GEM object's page lists refcounted
 instead of get/free.
From: Eric Anholt <eric@anholt.net>
To: Dave Airlie <airlied@linux.ie>
Cc: linux-kernel@vger.kernel.org, dri-devel@lists.sourceforge.net
In-Reply-To: <alpine.DEB.2.00.0903252251300.27027@skynet.skynet.ie>
References: <1238017510-26784-1-git-send-email-eric@anholt.net>
	 <1238017510-26784-2-git-send-email-eric@anholt.net>
	 <1238017510-26784-3-git-send-email-eric@anholt.net>
	 <alpine.DEB.2.00.0903252251300.27027@skynet.skynet.ie>
Content-Type: multipart/signed; micalg="pgp-sha1"; protocol="application/pgp-signature"; boundary="=-7EXiT16uarzeYDVqRZtV"
Date: Thu, 26 Mar 2009 12:59:15 -0700
Message-Id: <1238097555.8275.55.camel@gaiman.anholt.net>
Mime-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1969
Lines: 52


--=-7EXiT16uarzeYDVqRZtV
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

On Wed, 2009-03-25 at 22:52 +0000, Dave Airlie wrote:
> > We've wanted this for a few consumers that touch the pages directly (su=
ch as
> > the following commit), which have been doing the refcounting outside of
> > get/put pages.
>=20
> No idea if this is a valid point or not but whenever I see refcount that=20
> isn't a kref my internal, "should this be a kref" o-meter goes off.

All usage is under the struct mutex, since "get" is the transition from
0 -> 1 refcount, so I don't see how krefs would apply here (they're
suited more to refcounting objects after creation).

Our use of krefs for our GEM object refcounts is itself somewhat dubious
-- people have noted that we're spending a decent bit of CPU on the kref
usage, since the second hottest path is a loop of reffing objects (10-50
or so) up front, and loop of unreffing at the end.  And when we're doing
that reffing, we're holding a spinlock on the table we're looking it up
from, anyway!  So we end up with like 4 locked bus transactions per
object in exec that could easily be reduced to 2 total, if we made there
be a small "object referencing" lock covering the handle tables and
object refcounts.

--=20
Eric Anholt
eric@anholt.net                         eric.anholt@intel.com


--=-7EXiT16uarzeYDVqRZtV
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)

iEYEABECAAYFAknL3pAACgkQHUdvYGzw6vdgUwCfbGP30J62KEMOZtT+DIuOcm39
REQAmwRLbgn8GEF6IiURYqrDc8aojdVh
=QTOZ
-----END PGP SIGNATURE-----

--=-7EXiT16uarzeYDVqRZtV--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/