From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: "Tvrtko A. Ursulin" <tvrtko@ursulin.net>
Subject: Re: Resume after hibernation regression in 2.6.29
Date: Fri, 27 Mar 2009 00:08:59 +0100
User-Agent: KMail/1.11.1 (Linux/2.6.29-rc8-tst; KDE/4.2.1; x86_64; ; )
Cc: Pavel Machek <pavel@ucw.cz>, linux-pm@lists.linux-foundation.org,
       kernel list <linux-kernel@vger.kernel.org>,
       Tobias Diedrich <ranma+kernel@tdiedrich.de>,
       Ayaz Abdulla <aabdulla@nvidia.com>
References: <200903261920.32173.tvrtko@ursulin.net> <20090326223855.GF29836@elf.ucw.cz> <200903262304.24634.tvrtko@ursulin.net>
In-Reply-To: <200903262304.24634.tvrtko@ursulin.net>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200903270009.00479.rjw@sisk.pl>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 3446
Lines: 67

On Friday 27 March 2009, Tvrtko A. Ursulin wrote:
> On Thursday 26 March 2009 22:38:55 Pavel Machek wrote:
> > On Thu 2009-03-26 22:01:03, Tvrtko A. Ursulin wrote:
> > > On Thursday 26 March 2009 21:35:29 Rafael J. Wysocki wrote:
> > > > On Thursday 26 March 2009, Pavel Machek wrote:
> > > > > On Thu 2009-03-26 20:55:23, Tvrtko A. Ursulin wrote:
> > > > > > On Thursday 26 March 2009 20:18:40 Pavel Machek wrote:
> > > > > > > On Thu 2009-03-26 19:20:32, Tvrtko A. Ursulin wrote:
> > > > > > > > Hi guys,
> > > > > > > > I have been running custom compiled 2.6.28.7 in OpenSUSE 11.1
> > > > > > > > and using hiberation/resume daily as configured by the distro.
> > > > > > > > Yesterday I upgraded to 2.6.29 (make oldconfig from 2.6.28.7,
> > > > > > > > attached) and after resume networking (at least) does not work.
> > > > > > > > Reboot at this point takes very long because of timeouts on
> > > > > > > > CIFS and whatelse.
> > > > > > > >
> > > > > > > > Below is how /var/log/messagess looks for one cycle
> > > > > > > > (hibernate-resume-reboot) and I am also attaching kernel config
> > > > > > > > and /var/log/pm-suspend.log.
> > > > > > > >
> > > > > > > > You will probably notice evil nvidia.ko in there but don't
> > > > > > > > panic, it all happens without it as well. Tested from runlevel
> > > > > > > > 3 and by running pm-hibernate. After resume from that NIC LEDs
> > > > > > > > were off. I tried /etc/init.d/network restart but that hung so
> > > > > > > > I ^C and tried rmmod forcedeth && modprobe forcedeth && ifup
> > > > > > > > eth0 and after some time network went live again. Haven't had
> > > > > > > > time to test further though, so this is all pretty rough.
> > > > > > >
> > > > > > > Ok, can you try to rmmod forcedeth before hibernation, then
> > > > > > > insmod it after resume?
> > > > > >
> > > > > > Sure, after insmod and /etc/init.d/network start following resume
> > > > > > network was fine. Guess I could kludge that sequence into pm
> > > > > > scripts somehow but would rather avoid that since it slows down the
> > > > > > cycle and would make scripts non-stock.
> > > > >
> > > > > Ok, I guess you need to talk to forcedeth maintainers then... sounds
> > > > > like a forcedeth problem to me.
> > > >
> > > > I have a box with forcedeth somewhere here, I should be able to check
> > > > that in the next few days.
> > >
> > > Not a lot activity in forcedeth.c from 2.6.28 to 2.6.29 so I will CC two
> > > guys who commited changes in that period. Ayaz, Tobias, forcedeth does
> > > not seem to come up after hibernation well for me. Actual hardware is:
> > >
> > > 00:0f.0 Ethernet controller: nVidia Corporation MCP73 Ethernet (rev a2)
> > >
> > > Anything more I can do just shout!
> >
> > Actually yes. Testing forcedeth from 2.6.28 in 2.6.29 would be nice
> > way to prove problem is indeed in that module.
> 
> Good idea, I had to massage it a bit due to some API changes, but the end 
> result is a correct resume which proves that the problem really is in 
> forcedeth.

Well, since you can easily check what commits changed forcedeth between
2.6.28 and 2.6.29, you can find the one that introduced the problem for you.

Thanks,
Rafael
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/