Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756907AbZC0CwT (ORCPT ); Thu, 26 Mar 2009 22:52:19 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753266AbZC0CwD (ORCPT ); Thu, 26 Mar 2009 22:52:03 -0400 Received: from thunk.org ([69.25.196.29]:45123 "EHLO thunker.thunk.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751253AbZC0CwB (ORCPT ); Thu, 26 Mar 2009 22:52:01 -0400 Date: Thu, 26 Mar 2009 22:50:44 -0400 From: Theodore Tso To: Jeff Garzik Cc: Linus Torvalds , Ingo Molnar , Alan Cox , Arjan van de Ven , Andrew Morton , Peter Zijlstra , Nick Piggin , David Rees , Jesper Krogh , Linux Kernel Mailing List Subject: Re: [PATCH v2] issue storage device flush via sync_blockdev() Message-ID: <20090327025044.GM6239@mit.edu> Mail-Followup-To: Theodore Tso , Jeff Garzik , Linus Torvalds , Ingo Molnar , Alan Cox , Arjan van de Ven , Andrew Morton , Peter Zijlstra , Nick Piggin , David Rees , Jesper Krogh , Linux Kernel Mailing List References: <20090324184549.GE32307@mit.edu> <49C93AB0.6070300@garzik.org> <20090325093913.GJ27476@kernel.dk> <49CA86BD.6060205@garzik.org> <20090325194341.GB27476@kernel.dk> <49CA9346.6040108@garzik.org> <20090325212923.GA5620@havoc.gtf.org> <20090326032445.GA16999@havoc.gtf.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20090326032445.GA16999@havoc.gtf.org> User-Agent: Mutt/1.5.18 (2008-05-17) X-SA-Exim-Connect-IP: X-SA-Exim-Mail-From: tytso@mit.edu X-SA-Exim-Scanned: No (on thunker.thunk.org); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 811 Lines: 28 Jeff, FYI, I tried your patch; it causes the lvm process called out of the initramfs from an Ubuntu 8.10 system to blow up while trying to set up the root filesystem. The stack trace was: generic_make_request+0x2a3/0x2e6 trace_hardirqs_on_caller+0x111/0x135 mempool_alloc_slab+0xe/0x10 mempool_alloc+0x42/0xe0 submit_bio+0xad/0xb5 bio_alloc_bioset+0x21/0xfc blkdev_issue_flush+0x7f/0xfc syn_blockdev+0x2a/0x36 __blkdev_put_0x44/0x131 blkdev_put+0xa/0xc blkdev_close+0x2e/0x32 __fput+0xcf/0x15f fput+0x19/0x1b filp_close+0x51/0x5b sys_close+0x73/0xad - Ted -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/