Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754860AbZC0Htn (ORCPT ); Fri, 27 Mar 2009 03:49:43 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752970AbZC0Ht3 (ORCPT ); Fri, 27 Mar 2009 03:49:29 -0400 Received: from mx2.redhat.com ([66.187.237.31]:58091 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751823AbZC0Ht2 (ORCPT ); Fri, 27 Mar 2009 03:49:28 -0400 Date: Fri, 27 Mar 2009 08:46:55 +0100 From: Jiri Pirko To: David Miller Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org, jgarzik@pobox.com, shemminger@linux-foundation.org, bridge@lists.linux-foundation.org, fubar@us.ibm.com, bonding-devel@lists.sourceforge.net, kaber@trash.net, mschmidt@redhat.com, dada1@cosmosbay.com Subject: Re: [PATCH] bonding: allow bond in mode balance-alb to work properly in bridge -try4 Message-ID: <20090327074654.GC3377@psychotron.englab.brq.redhat.com> References: <20090313183303.GF3436@psychotron.englab.brq.redhat.com> <20090326155205.GA28868@psychotron.englab.brq.redhat.com> <20090327.003819.234492275.davem@davemloft.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20090327.003819.234492275.davem@davemloft.net> User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1377 Lines: 34 Fri, Mar 27, 2009 at 08:38:19AM CET, davem@davemloft.net wrote: >From: Jiri Pirko >Date: Thu, 26 Mar 2009 16:52:06 +0100 > >> (resend, updated changelog, hook moved into skb_bond_should_drop, >> skb_bond_should_drop ifdefed) >> >> Hi all. >> >> The problem is described in following bugzilla: >> https://bugzilla.redhat.com/show_bug.cgi?id=487763 > ... >> This patch solves the situation in the bonding without touching bridge code, >> as Patrick suggested. For every incoming frame to bonding it searches the >> destination address in slaves list and if any of slave addresses matches, it >> rewrites the address in frame by the adress of bonding master. This ensures that >> all frames comming thru the bonding in alb mode have the same address. >> >> Signed-off-by: Jiri Pirko > > >I don't like the hook, but if that's how it's best done.... Yes I agree with you, but I thing that for now it's the best way to do this. I picked this solution out of 3 that I had in mind and this is the lesser evil :) If anyone have any other solution please speak up. > >Patrick, please review this. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/