Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751867AbZC0LeZ (ORCPT ); Fri, 27 Mar 2009 07:34:25 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752425AbZC0LeL (ORCPT ); Fri, 27 Mar 2009 07:34:11 -0400 Received: from atrey.karlin.mff.cuni.cz ([195.113.26.193]:46660 "EHLO atrey.karlin.mff.cuni.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750913AbZC0LeJ (ORCPT ); Fri, 27 Mar 2009 07:34:09 -0400 Date: Fri, 27 Mar 2009 12:35:53 +0100 From: Pavel Machek To: James Morris Cc: kernel list , linux-security-module@vger.kernel.org, Greg KH , Linus Torvalds Subject: Re: TOMOYO in linux-next Message-ID: <20090327113553.GB2585@elf.ucw.cz> References: <20090326215031.GD29836@elf.ucw.cz> <20090327003620.GI29836@elf.ucw.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Warning: Reading this can be dangerous to your mental health. User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1413 Lines: 37 On Fri 2009-03-27 11:46:42, James Morris wrote: > On Fri, 27 Mar 2009, Pavel Machek wrote: > > > Hi! > > > > > As for the rest of the feedback, please work with the developers to fix > > > any bugs or lack of documentation. > > > > Apparently not even its user<->kernel interface was reviewed. This > > violates "one value per file in sysfs": > > > > [root@tomoyo]# cat /sys/kernel/security/tomoyo/meminfo > > Shared: 61440 > > Private: 69632 > > Dynamic: 768 > > Total: 131840 > > > > You can set memory quota by writing to this file. > > (Example) > > [root@tomoyo]# echo Shared: 2097152 > /sys/kernel/security/tomoyo/meminfo > > [root@tomoyo]# echo Private: 2097152 > /sys/kernel/security/tomoyo/meminfo > > This is not sysfs, it's securityfs, with their documentation showing it > mounted on /sys. Well, that's a bit better, but it still does not justify turning securityfs into procfs-like mess... when solution is so easy. Just use one value per file. -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/