From: Bodo Eggert <7eggert@gmx.de>
Subject: Re: [PATCH] Allow relatime to update atime once a day
To: Matthew Garrett <mjg@redhat.com>,
       Linus Torvalds <torvalds@linux-foundation.org>,
       Andrew Morton <akpm@linux-foundation.org>,
       Frans Pop <elendil@planet.nl>, mingo@elte.hu, tytso@mit.edu,
       jack@suse.cz, alan@lxorguk.ukuu.org.uk, arjan@infradead.org,
       a.p.zijlstra@chello.nl, npiggin@suse.de, jens.axboe@oracle.com,
       drees76@gmail.com, jesper@krogh.cc, linux-kernel@vger.kernel.org,
       oleg@redhat.com, roland@redhat.com, willy@linux.intel.com,
       vaurora@redhat.com
Reply-To: 7eggert@gmx.de
Date: Fri, 27 Mar 2009 20:34:55 +0100
References: <cjKHX-5MF-17@gated-at.bofh.it> <cjLb2-6no-13@gated-at.bofh.it> <cjTLl-3ln-15@gated-at.bofh.it> <cjW6r-72f-21@gated-at.bofh.it> <cjYrG-2u0-23@gated-at.bofh.it> <cjZ4h-3jp-21@gated-at.bofh.it> <cjZQH-4AG-21@gated-at.bofh.it> <ck0a6-51w-39@gated-at.bofh.it> <ck0D7-5Ua-9@gated-at.bofh.it> <ck1IK-7zR-19@gated-at.bofh.it>
User-Agent: KNode/0.10.4
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7Bit
Message-Id: <E1LnHpP-0001kk-PW@be1.7eggert.dyndns.org>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 675
Lines: 18

Matthew Garrett <mjg@redhat.com> wrote:

> --- a/fs/inode.c

> +
> +     if (!relatime_need_update(mnt, inode, now))
> +             goto out;
> +
->  if (timespec_equal(&inode->i_atime, &now))
->  goto out;

timespec_equal is now duplicate, because:

> +static int relatime_need_update(struct vfsmount *mnt, struct inode *inode,
..
> +     if (timespec_compare(&inode->i_mtime, &inode->i_atime) >= 0)
> +             return 1;


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/