Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757023AbZC0T7T (ORCPT ); Fri, 27 Mar 2009 15:59:19 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753532AbZC0T7D (ORCPT ); Fri, 27 Mar 2009 15:59:03 -0400 Received: from mail-in-01.arcor-online.net ([151.189.21.41]:42534 "EHLO mail-in-01.arcor-online.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753430AbZC0T7B (ORCPT ); Fri, 27 Mar 2009 15:59:01 -0400 X-DKIM: Sendmail DKIM Filter v2.8.2 mail-in-03.arcor-online.net 5EB792C2E44 From: Bodo Eggert <7eggert@gmx.de> Subject: Re: [PATCH] Allow relatime to update atime once a day To: Matthew Garrett , Linus Torvalds , Andrew Morton , Frans Pop , mingo@elte.hu, tytso@mit.edu, jack@suse.cz, alan@lxorguk.ukuu.org.uk, arjan@infradead.org, a.p.zijlstra@chello.nl, npiggin@suse.de, jens.axboe@oracle.com, drees76@gmail.com, jesper@krogh.cc, linux-kernel@vger.kernel.org, oleg@redhat.com, roland@redhat.com, willy@linux.intel.com, vaurora@redhat.com Reply-To: 7eggert@gmx.de Date: Fri, 27 Mar 2009 20:58:55 +0100 References: User-Agent: KNode/0.10.4 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7Bit Message-Id: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 819 Lines: 19 Matthew Garrett wrote: > diff --git a/fs/inode.c b/fs/inode.c > index 0487ddb..057c92b 100644 > --- a/fs/inode.c > now = current_fs_time(inode->i_sb); > + > + if (!relatime_need_update(mnt, inode, now)) > + goto out; > + > if (timespec_equal(&inode->i_atime, &now)) > goto out; Forget what I just said, I should rather read than assume. But I'm wondering if inlining this once-used function would be a good thing, since relatime is supposed to be a common option? Otherwise, I'd pull the flags check out and avoid the function call. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/