Message-ID: <49CD564E.6050101@msgid.tls.msk.ru>
Date: Sat, 28 Mar 2009 01:42:22 +0300
From: Michael Tokarev <mjt@tls.msk.ru>
Organization: Telecom Service, JSC
User-Agent: Mozilla-Thunderbird 2.0.0.19 (X11/20090103)
MIME-Version: 1.0
To: nicolas sitbon <nicolas.sitbon@gmail.com>
CC: linux-kernel@vger.kernel.org
Subject: Re: epoll_ctl and const correctness
References: <84a01a8b0903250545n799a8727o1faad60c8eaf372e@mail.gmail.com>	 <49CAA055.5060603@goop.org>	 <84a01a8b0903251437l9f9059s3c548b5d35ea47d4@mail.gmail.com>	 <84a01a8b0903270244s146ca50cr2758d36c2d9d77cd@mail.gmail.com>	 <49CD4967.2090606@msgid.tls.msk.ru>	 <84a01a8b0903271517t668c6276l7fe098d74c24b836@mail.gmail.com> <84a01a8b0903271530of8d43ffhf77e7ba73e309f75@mail.gmail.com>
In-Reply-To: <84a01a8b0903271530of8d43ffhf77e7ba73e309f75@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1297
Lines: 40

nicolas sitbon wrote:
> I was looking at libevent of niels provos, and even him, is apparently
> doing a mistake :
> 
> static int
> epoll_add(void *arg, struct event *ev)
> {
> 	struct epollop *epollop = arg;
> 	struct epoll_event epev = {0, {0}};
> 
>         /* ... some code here ... */
> 	if (epoll_ctl(epollop->epfd, op, ev->ev_fd, &epev) == -1)
> 			return (-1);
> 
> 	/* Update events responsible */
> 	if (ev->ev_events & EV_READ)
> 		evep->evread = ev;
> 	if (ev->ev_events & EV_WRITE)
> 		evep->evwrite = ev;
> 
> 	return (0);
> }
> 
> the structure pointed to by &epev is allocated on the stack, so how
> the kernel could keep track of it?

I've no idea what are you talking about and what exactly
is your problem.  Both the examples (one at cplayer.org and
another above) gives correct usage of epoll.  If you don't
understand it, well, I'd suggest reading some documentation
first, maybe in kernel, maybe in glibc, maybe numerous
available on the net.  And all the numerous examples too,
which you quote as, for some reason, wrong.

/mjt
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/