Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1764408AbZC0Xno (ORCPT ); Fri, 27 Mar 2009 19:43:44 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1762379AbZC0X2I (ORCPT ); Fri, 27 Mar 2009 19:28:08 -0400 Received: from metis.ext.pengutronix.de ([92.198.50.35]:48510 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1761650AbZC0X1m (ORCPT ); Fri, 27 Mar 2009 19:27:42 -0400 From: =?utf-8?q?Uwe=20Kleine-K=C3=B6nig?= To: linux-kernel@vger.kernel.org Cc: Andrew Morton , Jouni Hogander , Kalle Jokiniemi , Greg Kroah-Hartman , David Brownell , Tony Lindgren , Kevin Hilman , Felipe Balbi Subject: [PATCH 52/58] move twl4030_usb's probe function to .devinit.text Date: Sat, 28 Mar 2009 00:27:13 +0100 Message-Id: <1238196439-16535-52-git-send-email-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 1.6.2 In-Reply-To: <20090327232153.GA16348@pengutronix.de> References: <20090327232153.GA16348@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-SA-Exim-Connect-IP: 2001:6f8:1178:2:215:17ff:fe12:23b0 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1790 Lines: 44 A pointer to twl4030_usb_probe is passed to the core via platform_driver_register and so the function must not disappear when the .init sections are discarded. Otherwise (if also having HOTPLUG=y) unbinding and binding a device to the driver via sysfs will result in an oops as does a device being registered late. An alternative to this patch is using platform_driver_probe instead of platform_driver_register plus removing the pointer to the probe function from the struct platform_driver. Signed-off-by: Uwe Kleine-König Cc: Jouni Hogander Cc: Kalle Jokiniemi Cc: Greg Kroah-Hartman Cc: Andrew Morton Cc: David Brownell Cc: Tony Lindgren Cc: Kevin Hilman Cc: Felipe Balbi --- drivers/usb/otg/twl4030-usb.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/usb/otg/twl4030-usb.c b/drivers/usb/otg/twl4030-usb.c index d9478d0..c34e639 100644 --- a/drivers/usb/otg/twl4030-usb.c +++ b/drivers/usb/otg/twl4030-usb.c @@ -641,7 +641,7 @@ static int twl4030_set_host(struct otg_transceiver *x, struct usb_bus *host) return 0; } -static int __init twl4030_usb_probe(struct platform_device *pdev) +static int __devinit twl4030_usb_probe(struct platform_device *pdev) { struct twl4030_usb_data *pdata = pdev->dev.platform_data; struct twl4030_usb *twl; -- 1.6.2 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/