Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1763290AbZC0Xpp (ORCPT ); Fri, 27 Mar 2009 19:45:45 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1762614AbZC0X2M (ORCPT ); Fri, 27 Mar 2009 19:28:12 -0400 Received: from metis.ext.pengutronix.de ([92.198.50.35]:48505 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1761513AbZC0X1m (ORCPT ); Fri, 27 Mar 2009 19:27:42 -0400 From: =?utf-8?q?Uwe=20Kleine-K=C3=B6nig?= To: linux-kernel@vger.kernel.org Cc: Andrew Morton , Alan Cox , Wim Van Sebroeck , Felipe Balbi , "George G. Davis" Subject: [PATCH 35/58] move omap_wdt's probe function to .devinit.text Date: Sat, 28 Mar 2009 00:26:56 +0100 Message-Id: <1238196439-16535-35-git-send-email-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 1.6.2 In-Reply-To: <20090327232153.GA16348@pengutronix.de> References: <20090327232153.GA16348@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-SA-Exim-Connect-IP: 2001:6f8:1178:2:215:17ff:fe12:23b0 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1577 Lines: 41 A pointer to omap_wdt_probe is passed to the core via platform_driver_register and so the function must not disappear when the .init sections are discarded. Otherwise (if also having HOTPLUG=y) unbinding and binding a device to the driver via sysfs will result in an oops as does a device being registered late. An alternative to this patch is using platform_driver_probe instead of platform_driver_register plus removing the pointer to the probe function from the struct platform_driver. Signed-off-by: Uwe Kleine-König Cc: Alan Cox Cc: Wim Van Sebroeck Cc: Felipe Balbi Cc: George G. Davis Cc: Andrew Morton --- drivers/watchdog/omap_wdt.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/watchdog/omap_wdt.c b/drivers/watchdog/omap_wdt.c index 2f2ce74..c9c14dd 100644 --- a/drivers/watchdog/omap_wdt.c +++ b/drivers/watchdog/omap_wdt.c @@ -269,7 +269,7 @@ static const struct file_operations omap_wdt_fops = { .release = omap_wdt_release, }; -static int __init omap_wdt_probe(struct platform_device *pdev) +static int __devinit omap_wdt_probe(struct platform_device *pdev) { struct resource *res, *mem; struct omap_wdt_dev *wdev; -- 1.6.2 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/