DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws;
  s=s1024; d=pacbell.net;
  h=Received:X-YMail-OSG:X-Yahoo-Newman-Property:From:To:Subject:Date:User-Agent:Cc:References:In-Reply-To:MIME-Version:Content-Type:Content-Transfer-Encoding:Content-Disposition:Message-Id;
  b=fieuZuSwVcdKaXk7WZft/Glzf8P/SAcDIl77j1aChRmvxWXnxqUgm+ELfv4zLzY6EZKeMhiueOJXzb/lWLCdCo5CuWOMcijohfYDWNH+n2ndAI4A+sjgHPnFAsopwFqWSNU1pFfYL6L+i+qeUjaK8ov/w16p+dirO/HyccshucU=  ;
From: David Brownell <david-b@pacbell.net>
To: "Uwe =?iso-8859-1?q?Kleine-K=F6nig?=" 
	<u.kleine-koenig@pengutronix.de>
Subject: Re: [PATCH 04/58] move at91_ether's probe function to .devinit.text
Date: Fri, 27 Mar 2009 17:09:37 -0700
User-Agent: KMail/1.9.10
Cc: linux-kernel@vger.kernel.org, Andrew Morton <akpm@linux-foundation.org>,
       "David S. Miller" <davem@davemloft.net>,
       Jeff Garzik <jgarzik@redhat.com>,
       Paulius Zaleckas <paulius.zaleckas@teltonika.lt>,
       Marc Pignat <marc.pignat@hevs.ch>, Andrew Victor <linux@maxim.org.za>,
       Roel Kluin <12o3l@tiscali.nl>
References: <20090327232153.GA16348@pengutronix.de> <1238196439-16535-4-git-send-email-u.kleine-koenig@pengutronix.de>
In-Reply-To: <1238196439-16535-4-git-send-email-u.kleine-koenig@pengutronix.de>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 8bit
Content-Disposition: inline
Message-Id: <200903271709.38383.david-b@pacbell.net>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 951
Lines: 25

On Friday 27 March 2009, Uwe Kleine-K?nig wrote:
> An alternative to this patch is using platform_driver_probe instead of
> platform_driver_register plus removing the pointer to the probe function
> from the struct platform_driver.

IMO that's preferable for this driver.  There's no
point in doing anything other than discarding the
probe() method after the driver has been set up;
it'd be doing nothing except wasting memory.

Same thing for ... pretty much all other drivers
for SoC platform devices.

In this series, you cc'd me on four OMAP drivers
(mmci-omap, mmci-omap-hs, omap-rng, omap_udc) which
I *know* that's a completely workable -- and far
preferable -- solution.  There might be others.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/