Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758208AbZC1Ksp (ORCPT ); Sat, 28 Mar 2009 06:48:45 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756783AbZC1Kri (ORCPT ); Sat, 28 Mar 2009 06:47:38 -0400 Received: from ftp.linux-mips.org ([213.58.128.207]:41541 "EHLO ftp.linux-mips.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753656AbZC1Krh (ORCPT ); Sat, 28 Mar 2009 06:47:37 -0400 Date: Sat, 28 Mar 2009 11:45:52 +0100 From: Ralf Baechle To: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= Cc: linux-kernel@vger.kernel.org, Andrew Morton , Wang Chen , "David S. Miller" , Jeff Garzik , Thomas Bogendoerfer Subject: Re: [PATCH 44/58] move sgiseeq's probe function to .devinit.text Message-ID: <20090328104552.GD17386@linux-mips.org> References: <20090327232153.GA16348@pengutronix.de> <1238196439-16535-44-git-send-email-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1238196439-16535-44-git-send-email-u.kleine-koenig@pengutronix.de> User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1212 Lines: 28 On Sat, Mar 28, 2009 at 12:27:05AM +0100, Uwe Kleine-K?nig wrote: > A pointer to sgiseeq_probe is passed to the core via > platform_driver_register and so the function must not disappear when the > .init sections are discarded. Otherwise (if also having HOTPLUG=y) > unbinding and binding a device to the driver via sysfs will result in an > oops as does a device being registered late. > > An alternative to this patch is using platform_driver_probe instead of > platform_driver_register plus removing the pointer to the probe function > from the struct platform_driver. > > Signed-off-by: Uwe Kleine-K?nig > Cc: Wang Chen > Cc: David S. Miller > Cc: Andrew Morton > Cc: Jeff Garzik > Cc: Thomas Bogendoerfer > Cc: Ralf Baechle Acked-by: Ralf Baechle Ralf -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/