Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756253AbZC1XfZ (ORCPT ); Sat, 28 Mar 2009 19:35:25 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752944AbZC1XfJ (ORCPT ); Sat, 28 Mar 2009 19:35:09 -0400 Received: from mx2.mail.elte.hu ([157.181.151.9]:54615 "EHLO mx2.mail.elte.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751857AbZC1XfH (ORCPT ); Sat, 28 Mar 2009 19:35:07 -0400 Date: Sun, 29 Mar 2009 00:34:38 +0100 From: Ingo Molnar To: Thomas Gleixner Cc: "H. Peter Anvin" , Sam Ravnborg , Alexey Dobriyan , Jaswinder Singh Rajput , x86 maintainers , LKML Subject: Re: [git-pull -tip] x86: include inverse Xmas tree patches Message-ID: <20090328233438.GA4957@elte.hu> References: <1238251730.2526.2.camel@ht.satnam> <20090328150746.GA3268@x200.localdomain> <20090328190350.GA30214@uranus.ravnborg.org> <49CEA3CD.105@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.18 (2008-05-17) X-ELTE-VirusStatus: clean X-ELTE-SpamScore: -1.5 X-ELTE-SpamLevel: X-ELTE-SpamCheck: no X-ELTE-SpamVersion: ELTE 2.0 X-ELTE-SpamCheck-Details: score=-1.5 required=5.9 tests=BAYES_00 autolearn=no SpamAssassin version=3.2.3 -1.5 BAYES_00 BODY: Bayesian spam probability is 0 to 1% [score: 0.0000] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1247 Lines: 27 * Thomas Gleixner wrote: > > Personally I'd prefer alphabetic order, sorting based on length > > isn't a complete ordering. Nearly all editors can sort > > alphabetically at the push of a key. > > I'd prefer if somebody would sit down and write a tool to analyse > the include hell instead of manually shuffling crap around to > avoid trivial merge conflicts. I have cleaned up enough stuff in > the x86 merger myself where I was able to cut the number of > includes at least in half just by staring at the gcc intermediate > files. We could do better and automate the analysis so we get down > to a handful of includes instead of including the world and more. I do not disagree with include file cleanups (we've done many of them in this cycle and in previous cycles), but note that the reduction in include files at the top of .c files actually increases the chance of patch conflicts: when a new include file is added by two patches to the same .c file. Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/