Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755260AbZC2Fyz (ORCPT ); Sun, 29 Mar 2009 01:54:55 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751404AbZC2Fyq (ORCPT ); Sun, 29 Mar 2009 01:54:46 -0400 Received: from hera.kernel.org ([140.211.167.34]:46313 "EHLO hera.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751364AbZC2Fyp (ORCPT ); Sun, 29 Mar 2009 01:54:45 -0400 Subject: Re: [git-pull -tip] x86: include inverse Xmas tree patches From: Jaswinder Singh Rajput To: Ingo Molnar Cc: x86 maintainers , LKML In-Reply-To: <20090328233545.GB4957@elte.hu> References: <1238251730.2526.2.camel@ht.satnam> <20090328233545.GB4957@elte.hu> Content-Type: text/plain Date: Sun, 29 Mar 2009 11:24:08 +0530 Message-Id: <1238306048.2472.14.camel@ht.satnam> Mime-Version: 1.0 X-Mailer: Evolution 2.24.5 (2.24.5-1.fc10) Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1480 Lines: 42 On Sun, 2009-03-29 at 00:35 +0100, Ingo Molnar wrote: > * Jaswinder Singh Rajput wrote: > > > The following changes since commit 29219683c46cb89edf5c58418b5305b14646d030: > > Ingo Molnar (1): > > Merge branches 'x86/apic', 'x86/cleanups', 'x86/mm', 'x86/pat', 'x86/setup' and 'x86/signal'; commit 'v2.6.29' into x86/core > > > > are available in the git repository at: > > > > git://git.kernel.org/pub/scm/linux/kernel/git/jaswinder/linux-2.6-Xmas.git x86/core > > > > Jaswinder Singh Rajput (49): > > Looks nice. > > Have you written a script for this? If yes, would you mind to share > it with us? Thanks, I have done this manually. Scripts can be helpful in ordering but will not be useful in many cases like: 1. Duplication of asm files (include/linux/xyz.h call asm/xyz.h file without any case or this case is always true in that file) 2. Remove unwanted files 3. Handle various ifdefs in include file 4. handling errors which can be generated by this ordering 5. do some more beautification where required 6. ordering of variables 7. and many more issues which I have not faced so far .. So because of above cases even you made scripts with AI, they will fail in many cases. -- JSR -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/