DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=message-id:date:from:user-agent:mime-version:to:cc:subject
         :references:in-reply-to:content-type:content-transfer-encoding;
        b=Gz3mU2Y5M3yvmS59rmCGHUtfisxtA4cmGOKD857NGd8STvnLVChauJbB7i3t43CBtV
         M8Vi2YxfKwr6feDFkejqgstMamRwalAJlnuC7MDnrqJZNvoMne4hvDCbwW0NeDUHCrDd
         0FdMYAHn14kZhzGSX18VWVfcnLtp8u4+xGC9k=
Message-ID: <49CF4FFA.8090904@gmail.com>
Date: Sun, 29 Mar 2009 12:39:54 +0200
From: Marcin Slusarz <marcin.slusarz@gmail.com>
User-Agent: Thunderbird 2.0.0.21 (X11/20090302)
MIME-Version: 1.0
To: ngupta@vflare.org
CC: Andrew Morton <akpm@linux-foundation.org>,
       Christoph Lameter <cl@linux-foundation.org>,
       Pekka Enberg <penberg@cs.helsinki.fi>, Ed Tomlinson <edt@aei.ca>,
       "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/3] xvmalloc memory allocator
References: <49CEEE5A.4080004@vflare.org> <49CEEF30.9060202@vflare.org>
In-Reply-To: <49CEEF30.9060202@vflare.org>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1470
Lines: 66

Nitin Gupta wrote:
> +static void stat_inc(u64 *value)
> +{
> +    (*value)++;
> +}
> +
> +static void stat_dec(u64 *value)
> +{
> +    (*value)--;
> +}

Why not open code it?

> +
> +static u32 test_flag(struct block_header *block, enum blockflags flag)
> +{
> +    return block->prev & (1 << flag);
> +}
> +
> +static void set_flag(struct block_header *block, enum blockflags flag)
> +{
> +    block->prev |= (1 << flag);
> +}
> +
> +static void clear_flag(struct block_header *block, enum blockflags flag)
> +{
> +    block->prev &= ~(1 << flag);
> +}

Why don't you use test_bit / __set_bit / __clear_bit directly?

> +struct xv_pool *xv_create_pool(void)
> +{
> +    int i;
> +    u32 ovhd_size;
> +    struct xv_pool *pool;
> +
> +    ovhd_size = roundup(sizeof(*pool), PAGE_SIZE);
> +    pool = kmalloc(ovhd_size, GFP_KERNEL);
> +    if (!pool)
> +        return NULL;
> +
> +    memset(pool, 0, ovhd_size);

Please use kzalloc.

> +
> +    for (i = 0; i < NUM_FREE_LISTS; i++) {
> +        pool->freelist[i].pagenum = 0;
> +        pool->freelist[i].offset = 0;
> +    }

It was already zeroed by memset.

> +
> +    spin_lock_init(&pool->lock);
> +
> +    return pool;
> +}
> +EXPORT_SYMBOL_GPL(xv_create_pool);
> +
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/