DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws;
  s=s1024; d=pacbell.net;
  h=Received:X-YMail-OSG:X-Yahoo-Newman-Property:From:To:Subject:Date:User-Agent:Cc:References:In-Reply-To:MIME-Version:Content-Type:Content-Transfer-Encoding:Content-Disposition:Message-Id;
  b=xhdy3YgYTgW0eoDUHHn1y/6wr+eAB99L9HgbIXROqkFBp5fGhp/a7Iv7SISILeU4pT9TT/TUo6pR4uiEmZFp78Q3bcfRVlsajRnvNf79wbG6lnPvq+8ZnZFtkralsj0HcRjCwBR2HPi+RbY2zVmDTKNEmlXOkn97UVNQ3U8waWk=  ;
From: David Brownell <david-b@pacbell.net>
To: Herbert Xu <herbert@gondor.apana.org.au>,
       "Uwe =?iso-8859-1?q?Kleine-K=F6nig?=" 
	<u.kleine-koenig@pengutronix.de>
Subject: Re: [PATCH 34/58] move omap_rng's probe function to .devinit.text
Date: Sun, 29 Mar 2009 12:03:53 -0700
User-Agent: KMail/1.9.10
Cc: linux-kernel@vger.kernel.org, Andrew Morton <akpm@linux-foundation.org>,
       Russell King <rmk+kernel@arm.linux.org.uk>,
       Patrick McHardy <kaber@trash.net>, Jan Engelhardt <jengelh@gmx.de>,
       Michael Buesch <mb@bu3sch.de>
References: <20090327232153.GA16348@pengutronix.de> <1238196439-16535-34-git-send-email-u.kleine-koenig@pengutronix.de> <20090329074731.GD11735@gondor.apana.org.au>
In-Reply-To: <20090329074731.GD11735@gondor.apana.org.au>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 8bit
Content-Disposition: inline
Message-Id: <200903291203.54301.david-b@pacbell.net>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1620
Lines: 41

On Sunday 29 March 2009, Herbert Xu wrote:
> On Sat, Mar 28, 2009 at 12:26:55AM +0100, Uwe Kleine-K?nig wrote:
> > A pointer to omap_rng_probe is passed to the core via
> > platform_driver_register and so the function must not disappear when the
> > .init sections are discarded.  Otherwise (if also having HOTPLUG=y)
> > unbinding and binding a device to the driver via sysfs will result in an
> > oops as does a device being registered late.
> > 
> > An alternative to this patch is using platform_driver_probe instead of
> > platform_driver_register plus removing the pointer to the probe function
> > from the struct platform_driver.

Reminder:  we're expecting such an updated version,
to replace this one.


> > Signed-off-by: Uwe Kleine-K?nig <u.kleine-koenig@pengutronix.de>
> > Cc: Russell King <rmk+kernel@arm.linux.org.uk>
> > Cc: David Brownell <dbrownell@users.sourceforge.net>
> > Cc: Herbert Xu <herbert@gondor.apana.org.au>
> > Cc: Patrick McHardy <kaber@trash.net>
> > Cc: Jan Engelhardt <jengelh@gmx.de>
> > Cc: Michael Buesch <mb@bu3sch.de>
> > Cc: Andrew Morton <akpm@linux-foundation.org>
> 
> Applied to cryptodev.  Thanks!
> -- 
> Visit Openswan at http://www.openswan.org/
> Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
> Home Page: http://gondor.apana.org.au/~herbert/
> PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
> 
> 


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/