Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753719AbZC3BwQ (ORCPT ); Sun, 29 Mar 2009 21:52:16 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756175AbZC3BwA (ORCPT ); Sun, 29 Mar 2009 21:52:00 -0400 Received: from srv5.dvmed.net ([207.36.208.214]:36017 "EHLO mail.dvmed.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756074AbZC3Bv7 (ORCPT ); Sun, 29 Mar 2009 21:51:59 -0400 Message-ID: <49D0258A.9020306@garzik.org> Date: Sun, 29 Mar 2009 21:51:06 -0400 From: Jeff Garzik User-Agent: Thunderbird 2.0.0.21 (X11/20090320) MIME-Version: 1.0 To: =?ISO-8859-1?Q?Fernando_Luis_V=E1zquez_Cao?= CC: Christoph Hellwig , Linus Torvalds , Theodore Tso , Ingo Molnar , Alan Cox , Arjan van de Ven , Andrew Morton , Peter Zijlstra , Nick Piggin , David Rees , Jesper Krogh , Linux Kernel Mailing List Subject: Re: [PATCH 2/5] ext3: call blkdev_issue_flush on fsync() References: <49C93AB0.6070300@garzik.org> <20090325093913.GJ27476@kernel.dk> <49CA86BD.6060205@garzik.org> <20090325194341.GB27476@kernel.dk> <49CA9346.6040108@garzik.org> <20090325212923.GA5620@havoc.gtf.org> <20090326032445.GA16999@havoc.gtf.org> <20090327205046.GA2036@havoc.gtf.org> <20090329082507.GA4242@infradead.org> <49D01F94.6000101@oss.ntt.co.jp> <49D02328.7060108@oss.ntt.co.jp> In-Reply-To: <49D02328.7060108@oss.ntt.co.jp> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Score: -4.4 (----) X-Spam-Report: SpamAssassin version 3.2.5 on srv5.dvmed.net summary: Content analysis details: (-4.4 points, 5.0 required) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 727 Lines: 20 Fernando Luis V?zquez Cao wrote: > To ensure that bits are truly on-disk after an fsync or fdatasync, we > should force a disk flush explicitly when there is dirty data/metadata > and the journal didn't emit a write barrier (either because metadata is > not being synched or barriers are disabled). > > Signed-off-by: Fernando Luis Vazquez Cao Your patches do not seem to propagate the issue-flush error code, even when it is easily available. Jeff -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/