Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757190AbZC3Cun (ORCPT ); Sun, 29 Mar 2009 22:50:43 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756511AbZC3Cue (ORCPT ); Sun, 29 Mar 2009 22:50:34 -0400 Received: from serv2.oss.ntt.co.jp ([222.151.198.100]:34812 "EHLO serv2.oss.ntt.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754595AbZC3Cud (ORCPT ); Sun, 29 Mar 2009 22:50:33 -0400 Message-ID: <49D03377.1040909@oss.ntt.co.jp> Date: Mon, 30 Mar 2009 11:50:31 +0900 From: =?ISO-8859-1?Q?Fernando_Luis_V=E1zquez_Cao?= User-Agent: Mozilla-Thunderbird 2.0.0.19 (X11/20090103) MIME-Version: 1.0 To: Jeff Garzik CC: Christoph Hellwig , Linus Torvalds , Theodore Tso , Ingo Molnar , Alan Cox , Arjan van de Ven , Andrew Morton , Peter Zijlstra , Nick Piggin , David Rees , Jesper Krogh , Linux Kernel Mailing List Subject: Re: [PATCH 2/5] ext3: call blkdev_issue_flush on fsync() References: <49C93AB0.6070300@garzik.org> <20090325093913.GJ27476@kernel.dk> <49CA86BD.6060205@garzik.org> <20090325194341.GB27476@kernel.dk> <49CA9346.6040108@garzik.org> <20090325212923.GA5620@havoc.gtf.org> <20090326032445.GA16999@havoc.gtf.org> <20090327205046.GA2036@havoc.gtf.org> <20090329082507.GA4242@infradead.org> <49D01F94.6000101@oss.ntt.co.jp> <49D02328.7060108@oss.ntt.co.jp> <49D0258A.9020306@garzik.org> In-Reply-To: <49D0258A.9020306@garzik.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 812 Lines: 23 Jeff Garzik wrote: > Fernando Luis V?zquez Cao wrote: >> To ensure that bits are truly on-disk after an fsync or fdatasync, we >> should force a disk flush explicitly when there is dirty data/metadata >> and the journal didn't emit a write barrier (either because metadata is >> not being synched or barriers are disabled). >> >> Signed-off-by: Fernando Luis Vazquez Cao > > Your patches do not seem to propagate the issue-flush error code, even > when it is easily available. Oops... you are right. I will fix that. Thanks! - Fernando -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/