Date: Mon, 30 Mar 2009 14:04:56 +0200
From: Haavard Skinnemoen <haavard.skinnemoen@atmel.com>
To: Erik Waling <erik.waling@konftel.se>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] macb: RLE and BNA handling
Message-ID: <20090330140456.07eb48b8@hskinnemoen-d830>
In-Reply-To: <1238060296.23641.8.camel@konftel>
References: <1231863713.10152.11.camel@konftel>
	<20090114111505.48d34949@hskinnemoen-d830>
	<1231928868.10152.31.camel@konftel>
	<20090114130322.483a7830@hskinnemoen-d830>
	<1232026671.10152.52.camel@konftel>
	<1238060296.23641.8.camel@konftel>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1133
Lines: 30

Erik Waling wrote:
> Have you had the time to check the patch below? These two issues still
> needs to be addressed.

Yeah...sorry for not responding earlier.

> If you are unsure of the BNA part you could at least pass the RLE part
> upstreams since it happens more frequently.

Right. I have to admit I'm not at all convinced about the BNA part...it
seems to me like the only scenario when it makes a difference is when
the ring is so small that it can't hold an entire frame. And if that's
the case, isn't the easiest solution to just increase the size of the
ring?

So, could you please split the patch up into the following parts:
  1. TX RLE handling
  2. Call macb_rx() regardless of the status
  3. Handle incomplete RX frames
  4. Special case for RX BNA

Then I can pass on the first three, and we can keep discussing the last
one, which is the one I'm not sure about.

Haavard
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/