Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760340AbZC3U07 (ORCPT ); Mon, 30 Mar 2009 16:26:59 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1760405AbZC3U0f (ORCPT ); Mon, 30 Mar 2009 16:26:35 -0400 Received: from fk-out-0910.google.com ([209.85.128.184]:21738 "EHLO fk-out-0910.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751937AbZC3U0d (ORCPT ); Mon, 30 Mar 2009 16:26:33 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:subject:date:user-agent:cc:references:in-reply-to :mime-version:content-disposition:message-id:content-type :content-transfer-encoding; b=fPnwmv0WXRUVhIozjBk6uygw4S92eSKpKR+60mUffUmFBhIhiXkCTup7kQqWiplhR7 pnP/X3JSQk4JSmqit3vxTPhh14jCNl0+xnNGhj91USqjWJn+U2+LtpDGao1Ue/Cpbm2j dDMdVJqJF4Uy70HqbAKbLTfKSX4+kMtDT6New= From: Bartlomiej Zolnierkiewicz To: Geert Uytterhoeven Subject: Re: [PATCH] de: drivers/ide/ide-atapi.c needs Date: Mon, 30 Mar 2009 22:29:31 +0200 User-Agent: KMail/1.11.1 (Linux/2.6.29-next-20090327-dirty; KDE/4.2.1; i686; ; ) Cc: linux-ide@vger.kernel.org, Linux Kernel Development , Dmitri Vorobiev References: In-Reply-To: MIME-Version: 1.0 Content-Disposition: inline Message-Id: <200903302229.31846.bzolnier@gmail.com> Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1823 Lines: 44 On Sunday 29 March 2009, Geert Uytterhoeven wrote: > On m68k: > | drivers/ide/ide-atapi.c: In function 'ide_io_buffers': > | drivers/ide/ide-atapi.c:87: error: implicit declaration of function 'sg_page' > | drivers/ide/ide-atapi.c:87: warning: passing argument 1 of 'PageHighMem' makes pointer from integer without a cast > | drivers/ide/ide-atapi.c:91: warning: passing argument 1 of 'kmap_atomic' makes pointer from integer without a cast > | drivers/ide/ide-atapi.c:96: error: implicit declaration of function 'sg_virt' > | drivers/ide/ide-atapi.c:96: warning: assignment makes pointer from integer without a cast > | drivers/ide/ide-atapi.c:107: error: implicit declaration of function 'sg_next' > | drivers/ide/ide-atapi.c:107: warning: assignment makes pointer from integer without a cast > > Signed-off-by: Geert Uytterhoeven thanks, applied [ Dmitri, sorry but m68k was faster than MIPS this time ;) ] > --- > No idea where it got introduced. 2.6.29 was fine. Hmm... the issue went unnoticed because it was mitigated in linux-next by ide_pio_bytes() conversion (resulting in ide_io_buffers() removal)... > drivers/ide/ide-atapi.c | 2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) > > diff --git a/drivers/ide/ide-atapi.c b/drivers/ide/ide-atapi.c > index 6adc5b4..445d157 100644 > --- a/drivers/ide/ide-atapi.c > +++ b/drivers/ide/ide-atapi.c > @@ -6,6 +6,8 @@ > #include > #include > #include > +#include > + > #include > > #ifdef DEBUG -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/