Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761538AbZC3U6W (ORCPT ); Mon, 30 Mar 2009 16:58:22 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755125AbZC3U6K (ORCPT ); Mon, 30 Mar 2009 16:58:10 -0400 Received: from srv5.dvmed.net ([207.36.208.214]:51420 "EHLO mail.dvmed.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752268AbZC3U6J (ORCPT ); Mon, 30 Mar 2009 16:58:09 -0400 Message-ID: <49D13222.5020608@garzik.org> Date: Mon, 30 Mar 2009 16:57:06 -0400 From: Jeff Garzik User-Agent: Thunderbird 2.0.0.21 (X11/20090320) MIME-Version: 1.0 To: Mark Lord CC: Jens Axboe , Linus Torvalds , =?UTF-8?B?RmVybmFuZG8gTHVpcyBWw6F6cXVleiBDYW8=?= , Christoph Hellwig , Theodore Tso , Ingo Molnar , Alan Cox , Arjan van de Ven , Andrew Morton , Peter Zijlstra , Nick Piggin , David Rees , Jesper Krogh , Linux Kernel Mailing List , chris.mason@oracle.com, david@fromorbit.com, tj@kernel.org Subject: Re: [PATCH 1/7] block: Add block_flush_device() References: <49D02328.7060108@oss.ntt.co.jp> <49D0258A.9020306@garzik.org> <49D03377.1040909@oss.ntt.co.jp> <49D0B535.2010106@oss.ntt.co.jp> <49D0B687.1030407@oss.ntt.co.jp> <20090330175544.GX5178@kernel.dk> <20090330185414.GZ5178@kernel.dk> <20090330201732.GB5178@kernel.dk> <49D13123.7040007@rtr.ca> In-Reply-To: <49D13123.7040007@rtr.ca> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -4.4 (----) X-Spam-Report: SpamAssassin version 3.2.5 on srv5.dvmed.net summary: Content analysis details: (-4.4 points, 5.0 required) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 828 Lines: 24 Mark Lord wrote: > Jens Axboe wrote: >> My point is that some file systems may or may not have different paths >> or optimizations depending on whether barriers are enabled and working >> or not. Apparently that's just reiserfs and Chris says we can remove it, >> so it is probably a moot point. > XFS appears to have something along those lines. > I believe it tries to disable the drive write caches > if it discovers that it cannot do cache flushes. Perhaps; but speaking specifically about blkdev_issue_flush() -- nobody checks its return value at the present time. Jeff -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/