Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751128AbZCaJRy (ORCPT ); Tue, 31 Mar 2009 05:17:54 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751921AbZCaJRg (ORCPT ); Tue, 31 Mar 2009 05:17:36 -0400 Received: from zeniv.linux.org.uk ([195.92.253.2]:48280 "EHLO ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752374AbZCaJRf (ORCPT ); Tue, 31 Mar 2009 05:17:35 -0400 Date: Tue, 31 Mar 2009 10:16:53 +0100 From: Al Viro To: Manish Katiyar Cc: Andrew Morton , trivial@kernel.org, LKML Subject: Re: [PATCH] : Code cleanup for fs/inode.c as per checkpatch.pl Message-ID: <20090331091653.GU28946@ZenIV.linux.org.uk> References: <20090330163619.d08ba85e.akpm@linux-foundation.org> <20090331060423.GR28946@ZenIV.linux.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1109 Lines: 21 On Tue, Mar 31, 2009 at 02:32:37PM +0530, Manish Katiyar wrote: > -static struct inode * find_inode(struct super_block * sb, struct hlist_head *head, int (*test)(struct inode *, void *), void *data) > +static struct inode *find_inode(struct super_block *sb, struct hlist_head *head, > + int (*test)(struct inode *, void *), void *data) If you are splitting it, split it all the way, esp. the last line. > -static struct inode * get_new_inode(struct super_block *sb, struct hlist_head *head, int (*test)(struct inode *, void *), int (*set)(struct inode *, void *), void *data) > +static struct inode *get_new_inode(struct super_block *sb, > + struct hlist_head *head, > + int (*test)(struct inode *, void *), > + int (*set)(struct inode *, void *), void *data) Ditto, and that's even more serious case - here 'void *data' part is really obfuscated. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/