Message-ID: <20020225223600.88950.qmail@web21303.mail.yahoo.com>
Date: Mon, 25 Feb 2002 14:36:00 -0800 (PST)
From: Christine Ames <clgisotti@yahoo.com>
Subject: RE: [PATCH] block_dev.c: fsync() on close() considered harmful
To: post linux-kernel <linux-kernel@vger.kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Sender: linux-kernel-owner@vger.kernel.org

Christoph Hellwig [hch@caldera.de] wrote:
> Hi Alan,
> 
> I don't see any standard specifying that fsync should be done on
> every blockdevice close.
> 
> Any chance you could add the below patch to the next -ac release?
> 
> 	Christoph

I am writing a partitionable block device driver for the 2.4 kernel.
Once the driver is loaded and the device mounted, reading, writing,
and ioctls work properly.

The driver becomes unstable after many mounts/unmounts, and I have
come to suspect that I am not calling fsync_dev() correctly.

I do call fsync_dev() on release as well as on remove.
Is this incorrect?  Can it lead to instability?  I've counted four
different ways in which the driver dies, including a call to 
BUG() in buffer.c...

Thank you,

Christine


__________________________________________________
Do You Yahoo!?
Yahoo! Sports - Coverage of the 2002 Olympic Games
http://sports.yahoo.com
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/