Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756968AbZCaTwO (ORCPT ); Tue, 31 Mar 2009 15:52:14 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753962AbZCaTvx (ORCPT ); Tue, 31 Mar 2009 15:51:53 -0400 Received: from yx-out-2324.google.com ([74.125.44.28]:13285 "EHLO yx-out-2324.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752235AbZCaTvw convert rfc822-to-8bit (ORCPT ); Tue, 31 Mar 2009 15:51:52 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :content-transfer-encoding; b=xwZW4Bbo5+Zs4jdSk/oIFmCwndpZd2+m1gSbRiuzhU+2ufpgJGInas6volixmdvqfX xBXSjB9XhcOcnfpqeldMVwmlvdLDxyqUs2ZXhD++LXE1bdDTKH5zA+xbp4+BGOH1Ebae qXx+OFZ5fxWr30fNlw+50rb/b7iGmyc/8A3AA= MIME-Version: 1.0 In-Reply-To: References: <49B1F934.5050006@kernel.org> <200903291319.15269.rjw@sisk.pl> <9929d2390903301436q1cd96e05x47d60cff72e41b4d@mail.gmail.com> <200903302339.33781.rjw@sisk.pl> Date: Tue, 31 Mar 2009 12:51:49 -0700 X-Google-Sender-Auth: 01cbbc55e9250045 Message-ID: <9929d2390903311251n43988214y6f1b2defa87e1a48@mail.gmail.com> Subject: Re: [Updated patch] Re: [PATCH] igb: fix kexec with igb From: Jeff Kirsher To: "Tantilov, Emil S" Cc: "Rafael J. Wysocki" , Yinghai Lu , Jesse Brandeburg , David Miller , Ingo Molnar , Andrew Morton , "linux-kernel@vger.kernel.org" , NetDev Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1295 Lines: 35 On Tue, Mar 31, 2009 at 12:14 PM, Tantilov, Emil S wrote: > > The patch checks out. I tested suspend/resume (including WOL) and kexec. There is only a small issue with warning on compile when CONFIG_PM is disabled: > > diff --git a/drivers/net/igb/igb_main.c b/drivers/net/igb/igb_main.c > index 13fe162..0a4f8f4 100644 > --- a/drivers/net/igb/igb_main.c > +++ b/drivers/net/igb/igb_main.c > @@ -135,8 +135,8 @@ static inline int igb_set_vf_rlpml(struct igb_adapter *, int, int); >  static int igb_set_vf_mac(struct igb_adapter *adapter, int, unsigned char *); >  static void igb_restore_vf_multicasts(struct igb_adapter *adapter); > > -static int igb_suspend(struct pci_dev *, pm_message_t); >  #ifdef CONFIG_PM > +static int igb_suspend(struct pci_dev *, pm_message_t); >  static int igb_resume(struct pci_dev *); >  #endif >  static void igb_shutdown(struct pci_dev *); > > Thanks, > Emil > Rafael - Based on Emil's testing, I will modify the patch with Emil's suggestion and push to Dave, ok? -- Cheers, Jeff -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/