Date: Tue, 31 Mar 2009 22:19:37 +0200
From: Martin Schwidefsky <schwidefsky@de.ibm.com>
To: Ivan Kokshaysky <ink@jurassic.park.msu.ru>
Cc: Tejun Heo <tj@kernel.org>, Ingo Molnar <mingo@elte.hu>,
       rusty@rustcorp.com.au, tglx@linutronix.de, x86@kernel.org,
       linux-kernel@vger.kernel.org, hpa@zytor.com,
       Paul Mundt <lethal@linux-sh.org>, rmk@arm.linux.org.uk,
       starvik@axis.com, ralf@linux-mips.org, davem@davemloft.net,
       cooloney@kernel.org, kyle@mcmartin.ca, matthew@wil.cx,
       grundler@parisc-linux.org, takata@linux-m32r.org,
       benh@kernel.crashing.org, rth@twiddle.net, heiko.carstens@de.ibm.com
Subject: Re: [GIT RFC] percpu: use dynamic percpu allocator as the default
 percpu allocator
Message-ID: <20090331221937.1cf4e29a@skybase>
In-Reply-To: <20090331191703.GA8250@jurassic.park.msu.ru>
References: <49C8FAC4.6060508@kernel.org>
	<20090325122738.42d105b7@skybase>
	<49CA1AC3.9080908@kernel.org>
	<20090325122241.GE11571@elte.hu>
	<49CA2345.70204@kernel.org>
	<20090325141330.2717dc97@skybase>
	<49CA2FBF.9000207@kernel.org>
	<20090325142525.2d31c522@skybase>
	<49CA32F6.2030408@kernel.org>
	<20090331185431.72ff1707@skybase>
	<20090331191703.GA8250@jurassic.park.msu.ru>
Organization: IBM Corporation
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1239
Lines: 35

On Tue, 31 Mar 2009 23:17:03 +0400
Ivan Kokshaysky <ink@jurassic.park.msu.ru> wrote:

> On Tue, Mar 31, 2009 at 06:54:31PM +0200, Martin Schwidefsky wrote:
> > I got the dynamic cpu allocator to work with the patch below. Anybody
> > with an objection against the SHIFT_PERCPU_VAR macro ?
> 
> That's fine with me.
> 
> > --- linux-next/arch/alpha/include/asm/percpu.h	2009-03-31 15:55:03.000000000 +0200
> > +++ linux-s390/arch/alpha/include/asm/percpu.h	2009-03-31 15:55:46.000000000 +0200
> > @@ -47,6 +47,8 @@ extern unsigned long __per_cpu_offset[NR
> >  		: "=&r"(__ptr), "=&r"(tmp_gp));		\
> >  	(typeof(&per_cpu_var(var)))(__ptr + (offset)); })
> >  
> > +#define SHIFT_PERCPU_VAR(var, offset) SHIFT_PERCPU_PTR(var, offset)
> > +
> 
> No, just do s/SHIFT_PERCPU_PTR/SHIFT_PERCPU_VAR/ in
> arch/alpha/include/asm/percpu.h and the rest of your patch would
> fix alpha as well.

Ok, cool. May I add an Acked-by?

-- 
blue skies,
   Martin.

"Reality continues to ruin my life." - Calvin.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/