Message-ID: <49D27F03.2070302@gmx.net>
Date: Tue, 31 Mar 2009 22:37:23 +0200
From: Witold Szczeponik <Witold.Szczeponik@gmx.net>
User-Agent: Thunderbird 2.0.0.21 (Windows/20090302)
MIME-Version: 1.0
To: yakui_zhao <yakui.zhao@intel.com>
CC: "linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>,
       "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
       "bjorn.helgaas@hp.com" <bjorn.helgaas@hp.com>,
       "abelay@mit.edu" <abelay@mit.edu>, "rjw@sisk.pl" <rjw@sisk.pl>
Subject: Re: [PATCH] PNPACPI: Enable PNPACPI _PSx Support, v3
References: <49D101DA.50201@gmx.net> <1238463939.3625.99.camel@localhost.localdomain>
In-Reply-To: <1238463939.3625.99.camel@localhost.localdomain>
Content-Type: text/plain; charset=ISO-8859-15; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1137
Lines: 33

yakui_zhao wrote:

>     Very good patch.
>     Do you have the hardware on which the dedicated power source is
> required by the serial port(PnP device) in your hand?
> 

Yes, I have an IBM ThinkPad 600E. I need this patch in order to
be able receive accurate time using a DCF77 receiver attached
to the serial port.

[snip]

>> -	if (ACPI_FAILURE(status))
>> +	if (ACPI_FAILURE(acpi_set_current_resources(handle, &buffer)))
>>   		ret = -EINVAL;
>> +	else if (acpi_bus_power_manageable(handle))
>> +		ret = acpi_bus_set_power(handle, ACPI_STATE_D0);
> How about changing the power state before calling _SRS object?

I recall reading something in the ACPI spec that says that the power
needs to be set after the device was enabled.  But the main driver
for this order (_SRS followed by _PS0) is the symmetry to the required
_PS3 followed by _DIS (according to the spec).

[snip]

--- Witold
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/