Date: Wed, 01 Apr 2009 10:21:47 +0900 (JST)
Message-Id: <20090401.102147.40646663.nemoto@toshiba-tops.co.jp>
To: lg@denx.de
Cc: linux-kernel@vger.kernel.org, dan.j.williams@intel.com,
       maciej.sosnowski@intel.com
Subject: Re: [PATCH] dmaengine: fix regression introduced by
 d6103085dfd83c13db65c3bd7e182f021d77c541
From: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
In-Reply-To: <Pine.LNX.4.64.0903311755540.4806@axis700.grange>
References: <Pine.LNX.4.64.0903311755540.4806@axis700.grange>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 836
Lines: 18

On Tue, 31 Mar 2009 18:07:34 +0200 (CEST), Guennadi Liakhovetski <lg@denx.de> wrote:
> chan is an index variable, used to loop over a list of channels, and here 
> it is used _after_ the loop, in which case it doesn't point to a DMA 
> channel struct anymore. Dereferencing it leads to a corruption of a random 
> memory location, which in my case was a pointer inside a clock struct. Fix 
> it by using a local variable pointing to the DMA device.
> 
> Signed-off-by: Guennadi Liakhovetski <lg@denx.de>

Oops!  your fix is correct.  Thank you for fixing this nasty bug.

---
Atsushi Nemoto
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/