Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754008AbZDAJE1 (ORCPT ); Wed, 1 Apr 2009 05:04:27 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1750885AbZDAJES (ORCPT ); Wed, 1 Apr 2009 05:04:18 -0400 Received: from smtp.nokia.com ([192.100.105.134]:47569 "EHLO mgw-mx09.nokia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750704AbZDAJER (ORCPT ); Wed, 1 Apr 2009 05:04:17 -0400 Message-ID: <49D32DAC.501@maxwell.research.nokia.com> Date: Wed, 01 Apr 2009 12:02:36 +0300 From: Sakari Ailus User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.1.19) Gecko/20081204 SeaMonkey/1.1.14 MIME-Version: 1.0 To: =?ISO-8859-1?Q?Uwe_Kleine-K=F6nig?= CC: "linux-kernel@vger.kernel.org" , Andrew Morton , Trilok Soni , Hans Verkuil , Mauro Carvalho Chehab Subject: Re: [PATCH 29/58] move omap24xxcam's probe function to .devinit.text References: <20090327232153.GA16348@pengutronix.de> <1238196439-16535-29-git-send-email-u.kleine-koenig@pengutronix.de> <49D31A5F.90108@nokia.com> <20090401082830.GA27668@pengutronix.de> In-Reply-To: <20090401082830.GA27668@pengutronix.de> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 8bit X-OriginalArrivalTime: 01 Apr 2009 09:02:40.0146 (UTC) FILETIME=[9C30BF20:01C9B2A8] X-Nokia-AV: Clean Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1597 Lines: 38 Uwe Kleine-K?nig wrote: > Hallo Sakari, > > On Wed, Apr 01, 2009 at 10:40:15AM +0300, Sakari Ailus wrote: >> ext Uwe Kleine-K?nig wrote: >>> A pointer to omap24xxcam_probe is passed to the core via >>> platform_driver_register and so the function must not disappear when the >>> .init sections are discarded. Otherwise (if also having HOTPLUG=y) >>> unbinding and binding a device to the driver via sysfs will result in an >>> oops as does a device being registered late. >>> >>> An alternative to this patch is using platform_driver_probe instead of >>> platform_driver_register plus removing the pointer to the probe function >>> from the struct platform_driver. >>> >>> Signed-off-by: Uwe Kleine-K?nig >>> Cc: Sakari Ailus >>> Cc: Trilok Soni >>> Cc: Hans Verkuil >>> Cc: Mauro Carvalho Chehab >>> Cc: Andrew Morton >>> --- >>> drivers/media/video/omap24xxcam.c | 2 +- >>> 1 files changed, 1 insertions(+), 1 deletions(-) >> Signed-off-by: Sakari Ailus > Does your S-o-b means you care for inclusion in mainline?[1] Or should > I record that as an Acked-by? Sorry. Take that as Acked-by. -- Sakari Ailus sakari.ailus@maxwell.research.nokia.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/