Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1762335AbZDAJNl (ORCPT ); Wed, 1 Apr 2009 05:13:41 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756272AbZDAJN1 (ORCPT ); Wed, 1 Apr 2009 05:13:27 -0400 Received: from fgwmail5.fujitsu.co.jp ([192.51.44.35]:49185 "EHLO fgwmail5.fujitsu.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754949AbZDAJN1 (ORCPT ); Wed, 1 Apr 2009 05:13:27 -0400 From: KOSAKI Motohiro To: KOSAKI Motohiro Subject: Re: add_to_swap_cache with GFP_ATOMIC ? Cc: kosaki.motohiro@jp.fujitsu.com, Hugh Dickins , Minchan Kim , linux-mm , lkml , Andrew Morton , Christoph Lameter , Nick Piggin In-Reply-To: <20090401165516.B1EB.A69D9226@jp.fujitsu.com> References: <20090401165516.B1EB.A69D9226@jp.fujitsu.com> Message-Id: <20090401181236.B1F4.A69D9226@jp.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Mailer: Becky! ver. 2.50 [ja] Date: Wed, 1 Apr 2009 18:13:22 +0900 (JST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 608 Lines: 13 > IOW, GFP_ATOMIC on add_to_swap() was introduced accidentally. the reason > was old add_to_page_cache() didn't have gfp_mask parameter and we didn't > have the reason of changing add_to_swap() behavior. > I think it don't have deeply reason and changing GFP_NOIO don't cause regression. "accidentally" is wrong word obiously. I mean "non strong intention". -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/